Skip to content

Fix Incorrect High Slat Angle Index #11405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchute merged 4 commits into from
Jan 28, 2026
+1 −1
Merged

Fix Incorrect High Slat Angle Index #11405

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d1f7feb
fix high slat angle idx
mitchute Jan 24, 2026
814479f
Merge branch 'develop' into fix-blind-slat-angle-idx
mitchute Jan 26, 2026
8978d8e
Merge branch 'develop' into fix-blind-slat-angle-idx
mitchute Jan 26, 2026
0954daa
Merge branch 'develop' into fix-blind-slat-angle-idx
mitchute Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/EnergyPlus/HeatBalanceSurfaceManager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3271,7 +3271,7 @@ void InitSolarHeatGains(EnergyPlusData &state)
Real64 ACosTlt = std::abs(Surface(SurfNum).CosTilt); // Absolute value of cosine of surface tilt angle

int slatIdxLo = surfShade.blind.slatAngIdxLo;
int slatIdxHi = surfShade.blind.slatAngIdxLo;
int slatIdxHi = surfShade.blind.slatAngIdxHi;
Copy link
Collaborator

@rraustad rraustad Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, why no diffs now?

Copy link
Collaborator Author

@mitchute mitchute Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah, it still thinks this is coming in from a forked repo, so it didn't run regressions. https://github.com/NatLabRockies/EnergyPlus/actions/runs/21322463790/job/61374316914?pr=11405

I've got a couple more quick touch-ups on #11404, and then we can get that merged. That will fix this.

Real64 interpFac = surfShade.blind.slatAngInterpFac;
auto const &dfAbsSlatLo = constructionSh.layerSlatBlindDfAbs(Lay)[slatIdxLo];
auto const &dfAbsSlatHi = constructionSh.layerSlatBlindDfAbs(Lay)[slatIdxHi];
Expand Down
Loading