Skip to content

Fix Tabular Annual Average Values with Unit Conversion #11410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mitchute wants to merge 2 commits into
base: develop
Choose a base branch
from
+9 −5
Open

Fix Tabular Annual Average Values with Unit Conversion #11410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb8b28d
pin testing badges to develop
mitchute Feb 2, 2026
03137b1
fix tabular monthly average value when conversion is applied
mitchute Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ This is the EnergyPlus Development Repository. EnergyPlus™ is a whole buildin

## Testing

[![](https://github.com/NatLabRockies/EnergyPlus/workflows/Code%20Integrity/badge.svg)](https://github.com/NatLabRockies/EnergyPlus/actions/workflows/test_code_integrity.yml)
[![](https://github.com/NatLabRockies/EnergyPlus/workflows/Documentation/badge.svg)](https://github.com/NatLabRockies/EnergyPlus/actions/workflows/build_documentation.yml)
[![](https://github.com/NatLabRockies/EnergyPlus/actions/workflows/test_code_integrity.yml/badge.svg?branch=develop)](https://github.com/NatLabRockies/EnergyPlus/actions/workflows/test_code_integrity.yml)
Copy link
Collaborator Author

@mitchute mitchute Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated. Pinning the README badges to the develop branch.

[![](https://github.com/NatLabRockies/EnergyPlus/actions/workflows/build_documentation.yml/badge.svg?branch=develop)](https://github.com/NatLabRockies/EnergyPlus/actions/workflows/build_documentation.yml)

Every commit and every release of EnergyPlus undergoes rigorous testing.
The testing consists of building EnergyPlus, of course, then there are unit tests, integration tests, API tests, and regression tests.
Expand Down
10 changes: 7 additions & 3 deletions src/EnergyPlus/OutputReportTabular.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7222,16 +7222,20 @@ void WriteMonthlyTables(EnergyPlusData &state)
maxVal = storedMinVal;
for (lMonth = 1; lMonth <= 12; ++lMonth) {
if (ort->MonthlyColumns(curCol).avgSum ==
OutputProcessor::StoreType::Average) { // if it is a average variable divide by duration
OutputProcessor::StoreType::Average) { // if it is an average variable divide by duration
if (ort->MonthlyColumns(curCol).duration(lMonth) != 0) {
curVal = ((ort->MonthlyColumns(curCol).reslt(lMonth) / ort->MonthlyColumns(curCol).duration(lMonth)) *
curConversionFactor) +
state.dataOutRptTab->curConversionOffset;
} else {
curVal = 0.0;
}
sumVal +=
(ort->MonthlyColumns(curCol).reslt(lMonth) * curConversionFactor) + state.dataOutRptTab->curConversionOffset;
if (ort->MonthlyColumns(curCol).duration(lMonth) > 0) {
sumVal += ((ort->MonthlyColumns(curCol).reslt(lMonth) / ort->MonthlyColumns(curCol).duration(lMonth) *
curConversionFactor) +
state.dataOutRptTab->curConversionOffset) *
ort->MonthlyColumns(curCol).duration(lMonth);
}
Comment on lines +7233 to +7238
Copy link
Collaborator Author

@mitchute mitchute Feb 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to divide reslt(lMonth) by the monthly duration, convert the units, then multiply back in the monthly duration so the annual average can be calculated later.

sumDuration += ort->MonthlyColumns(curCol).duration(lMonth);
} else {
curVal = (ort->MonthlyColumns(curCol).reslt(lMonth) * curConversionFactor) + state.dataOutRptTab->curConversionOffset;
Expand Down