Skip to content

Modify sizing string prefix from "Design Size" to "Autosized" for more clarity in table headers and sizing outputs #8805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
matthew-larson wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

Modify sizing string prefix from "Design Size" to "Autosized" for more clarity in table headers and sizing outputs #8805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cf83d11
Update all output reporting for consistency with Design Size and User…
matthew-larson May 27, 2021
da0229f
Fix clang formatting.
matthew-larson May 27, 2021
e67f4af
Fix clang formatting.
matthew-larson May 27, 2021
b20c10d
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into fix…
matthew-larson Jun 2, 2021
20910e6
Revert Autosizing sizing strings to original values.
matthew-larson Jun 3, 2021
3899d30
Change from Design Size to Autosized.
matthew-larson Jun 3, 2021
964f5f1
Fix clang formatting.
matthew-larson Jun 3, 2021
138be63
Fix clang formatting.
matthew-larson Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/output-details-and-examples/src/output-files/eplusout-eio.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3070,9 +3070,9 @@ \subsection{Component Sizing Information}\label{component-sizing-information}

~Component Sizing Information, Humidifier:Steam:Electric, HUMIDIFIER 1, Rated Power {[}W{]}, 9826.56303

Component Sizing Information, Humidifier:Steam:Gas, MAIN GAS HUMIDIFIER, Design Size Nominal Capacity Volume {[}m3/s{]}, 1.05405E-002
Component Sizing Information, Humidifier:Steam:Gas, MAIN GAS HUMIDIFIER, Autosized Nominal Capacity Volume {[}m3/s{]}, 1.05405E-002

Component Sizing Information, Humidifier:Steam:Gas, MAIN GAS HUMIDIFIER, Design Size Rated Power {[}W{]}, 103710.42776
Component Sizing Information, Humidifier:Steam:Gas, MAIN GAS HUMIDIFIER, Autosized Rated Power {[}W{]}, 103710.42776

\subsubsection{Field: \textless{}Component Sizing Information\textgreater{}}\label{field-component-sizing-information}

Expand Down
18 changes: 9 additions & 9 deletions src/EnergyPlus/Autosizing/Base.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ void BaseSizer::selectSizerOutput(EnergyPlusData &state, bool &errorsFound)
} else if (this->wasAutoSized && this->dataFractionUsedForSizing > 0.0 && this->dataConstantUsedForSizing > 0.0) {
this->autoSizedValue = this->dataFractionUsedForSizing * this->dataConstantUsedForSizing;
this->reportSizerOutput(
state, this->compType, this->compName, "Design Size " + this->sizingStringScalable + this->sizingString, this->autoSizedValue);
state, this->compType, this->compName, "Autosized " + this->sizingStringScalable + this->sizingString, this->autoSizedValue);
} else if (!this->wasAutoSized &&
(this->autoSizedValue == this->originalValue || this->autoSizedValue == 0.0)) { // no sizing run done or autosizes to 0
this->autoSizedValue = this->originalValue;
Expand All @@ -372,15 +372,15 @@ void BaseSizer::selectSizerOutput(EnergyPlusData &state, bool &errorsFound)
this->reportSizerOutput(
state, this->compType, this->compName, "User-Specified " + this->sizingStringScalable + this->sizingString, this->autoSizedValue);
} else {
this->reportSizerOutput(state, this->compType, this->compName, "Design Size " + this->sizingString, this->autoSizedValue);
this->reportSizerOutput(state, this->compType, this->compName, "Autosized " + this->sizingString, this->autoSizedValue);
}
} else if (this->autoSizedValue >= 0.0 && this->originalValue > 0.0) {
if ((std::abs(this->autoSizedValue - this->originalValue) / this->originalValue) > state.dataSize->AutoVsHardSizingThreshold) {
if (this->dataAutosizable)
this->reportSizerOutput(state,
this->compType,
this->compName,
"Design Size " + this->sizingString,
"Autosized " + this->sizingString,
this->autoSizedValue,
"User-Specified " + this->sizingStringScalable + this->sizingString,
this->originalValue);
Expand All @@ -400,7 +400,7 @@ void BaseSizer::selectSizerOutput(EnergyPlusData &state, bool &errorsFound)
msg = format("User-Specified {}{} = {:.5R}", this->sizingStringScalable, this->sizingString, this->originalValue);
this->addErrorMessage(msg);
ShowContinueError(state, msg);
msg = format("differs from Design Size {} = {:.5R}", this->sizingString, this->autoSizedValue);
msg = format("differs from Autosized {} = {:.5R}", this->sizingString, this->autoSizedValue);
this->addErrorMessage(msg);
ShowContinueError(state, msg);
msg = "This may, or may not, indicate mismatched component sizes.";
Expand Down Expand Up @@ -481,19 +481,19 @@ void BaseSizer::select2StgDXHumCtrlSizerOutput(EnergyPlusData &state, bool &erro
this->reportSizerOutput(
state, this->compType, this->compName, "User-Specified " + this->sizingStringScalable + this->sizingString, this->autoSizedValue);
} else {
this->reportSizerOutput(state, this->compType, this->compName, "Design Size " + this->sizingString, this->autoSizedValue);
this->reportSizerOutput(state, this->compType, this->compName, "Autosized " + this->sizingString, this->autoSizedValue);
}
if (UtilityRoutines::SameString(this->compType, "COIL:COOLING:DX:TWOSTAGEWITHHUMIDITYCONTROLMODE")) {
this->autoSizedValue *= (1 - this->dataBypassFrac); // now reapply for second message and remianing simulation calcs
this->reportSizerOutput(
state, this->compType, this->compName, "Design Size " + this->sizingString + " ( non-bypassed )", this->autoSizedValue);
state, this->compType, this->compName, "Autosized " + this->sizingString + " ( non-bypassed )", this->autoSizedValue);
}
} else if (this->autoSizedValue >= 0.0 && this->originalValue > 0.0) {
if ((std::abs(this->autoSizedValue - this->originalValue) / this->originalValue) > state.dataSize->AutoVsHardSizingThreshold) {
this->reportSizerOutput(state,
this->compType,
this->compName,
"Design Size " + this->sizingString,
"Autosized " + this->sizingString,
this->autoSizedValue,
"User-Specified " + this->sizingStringScalable + this->sizingString,
this->originalValue);
Expand All @@ -503,7 +503,7 @@ void BaseSizer::select2StgDXHumCtrlSizerOutput(EnergyPlusData &state, bool &erro
this->reportSizerOutput(state,
this->compType,
this->compName,
"Design Size " + this->sizingString + " ( non-bypassed )",
"Autosized " + this->sizingString + " ( non-bypassed )",
this->autoSizedValue,
"User-Specified " + this->sizingStringScalable + this->sizingString + " ( non-bypassed )",
this->originalValue);
Expand Down Expand Up @@ -531,7 +531,7 @@ void BaseSizer::select2StgDXHumCtrlSizerOutput(EnergyPlusData &state, bool &erro
msg = format("User-Specified {}{} = {:.5R}", this->sizingStringScalable, this->sizingString, this->originalValue);
this->addErrorMessage(msg);
ShowContinueError(state, msg);
msg = format("differs from Design Size {} = {:.5R}", this->sizingString, this->autoSizedValue);
msg = format("differs from Autosized {} = {:.5R}", this->sizingString, this->autoSizedValue);
this->addErrorMessage(msg);
ShowContinueError(state, msg);
msg = "This may, or may not, indicate mismatched component sizes.";
Expand Down
2 changes: 1 addition & 1 deletion src/EnergyPlus/Autosizing/HeatingWaterDesCoilLoadUsedForUASizing.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ struct HeatingWaterDesCoilLoadUsedForUASizer : BaseSizer
HeatingWaterDesCoilLoadUsedForUASizer()
{
this->sizingType = AutoSizingType::HeatingWaterDesCoilLoadUsedForUASizing;
this->sizingString = "Water Heating Design Coil Load for UA Sizing";
this->sizingString = "Design Water Heating Design Coil Load for UA Sizing";
}
~HeatingWaterDesCoilLoadUsedForUASizer() = default;

Expand Down
14 changes: 7 additions & 7 deletions src/EnergyPlus/BaseboardRadiator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,15 +827,15 @@ namespace BaseboardRadiator {
BaseSizer::reportSizerOutput(state,
cCMO_BBRadiator_Water,
baseboard->Baseboard(BaseboardNum).EquipID,
"Design Size Maximum Water Flow Rate [m3/s]",
"Autosized Maximum Water Flow Rate [m3/s]",
WaterVolFlowRateMaxDes);
} else { // hard-sized with sizing data
if (baseboard->Baseboard(BaseboardNum).WaterVolFlowRateMax > 0.0 && WaterVolFlowRateMaxDes > 0.0) {
WaterVolFlowRateMaxUser = baseboard->Baseboard(BaseboardNum).WaterVolFlowRateMax;
BaseSizer::reportSizerOutput(state,
cCMO_BBRadiator_Water,
baseboard->Baseboard(BaseboardNum).EquipID,
"Design Size Maximum Water Flow Rate [m3/s]",
"Autosized Maximum Water Flow Rate [m3/s]",
WaterVolFlowRateMaxDes,
"User-Specified Maximum Water Flow Rate [m3/s]",
WaterVolFlowRateMaxUser);
Expand All @@ -849,7 +849,7 @@ namespace BaseboardRadiator {
ShowContinueError(state,
format("User-Specified Maximum Water Flow Rate of {:.5R} [m3/s]", WaterVolFlowRateMaxUser));
ShowContinueError(
state, format("differs from Design Size Maximum Water Flow Rate of {:.5R} [m3/s]", WaterVolFlowRateMaxDes));
state, format("differs from Autosized Maximum Water Flow Rate of {:.5R} [m3/s]", WaterVolFlowRateMaxDes));
ShowContinueError(state, "This may, or may not, indicate mismatched component sizes.");
ShowContinueError(state, "Verify that the value entered is intended and is consistent with other components.");
}
Expand Down Expand Up @@ -1021,26 +1021,26 @@ namespace BaseboardRadiator {
BaseSizer::reportSizerOutput(state,
cCMO_BBRadiator_Water,
baseboard->Baseboard(BaseboardNum).EquipID,
"Design Size U-Factor Times Area Value [W/K]",
"Autosized U-Factor Times Area Value [W/K]",
UADes);
} else { // Hard-sized with sizing data
baseboard->Baseboard(BaseboardNum).UA = UAUser; // need to put this back as HWBaseboardUAResidual will have reset it, CR9377
if (UAUser > 0.0 && UADes > 0.0) {
BaseSizer::reportSizerOutput(state,
cCMO_BBRadiator_Water,
baseboard->Baseboard(BaseboardNum).EquipID,
"Design Size U-Factor Times Area Value [W/K]",
"Autosized U-Factor Times Area Value [W/K]",
UADes,
"User-Specified U-Factor Times Area Value [W/K]",
UAUser);
// Report difference between design size and hard-sized values
// Report difference between Autosized and hard-sized values
if (state.dataGlobal->DisplayExtraWarnings) {
if ((std::abs(UADes - UAUser) / UAUser) > state.dataSize->AutoVsHardSizingThreshold) {
ShowMessage(state,
"SizeBaseboard: Potential issue with equipment sizing for ZoneHVAC:Baseboard:Convective:Water=\"" +
baseboard->Baseboard(BaseboardNum).EquipID + "\".");
ShowContinueError(state, format("User-Specified U-Factor Times Area Value of {:.2R} [W/K]", UAUser));
ShowContinueError(state, format("differs from Design Size U-Factor Times Area Value of {:.2R} [W/K]", UADes));
ShowContinueError(state, format("differs from Autosized U-Factor Times Area Value of {:.2R} [W/K]", UADes));
ShowContinueError(state, "This may, or may not, indicate mismatched component sizes.");
ShowContinueError(state, "Verify that the value entered is intended and is consistent with other components.");
}
Expand Down
8 changes: 4 additions & 4 deletions src/EnergyPlus/BoilerSteam.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,10 +523,10 @@ namespace BoilerSteam {
if (this->NomCapWasAutoSized) {
this->NomCap = tmpNomCap;
if (state.dataPlnt->PlantFinalSizesOkayToReport) {
BaseSizer::reportSizerOutput(state, "Boiler:Steam", this->Name, "Design Size Nominal Capacity [W]", tmpNomCap);
BaseSizer::reportSizerOutput(state, "Boiler:Steam", this->Name, "Autosized Nominal Capacity [W]", tmpNomCap);
}
if (state.dataPlnt->PlantFirstSizesOkayToReport) {
BaseSizer::reportSizerOutput(state, "Boiler:Steam", this->Name, "Initial Design Size Nominal Capacity [W]", tmpNomCap);
BaseSizer::reportSizerOutput(state, "Boiler:Steam", this->Name, "Initial Autosized Nominal Capacity [W]", tmpNomCap);
}
} else { // Hard-sized with sizing data
if (this->NomCap > 0.0 && tmpNomCap > 0.0) {
Expand All @@ -535,15 +535,15 @@ namespace BoilerSteam {
BaseSizer::reportSizerOutput(state,
"Boiler:Steam",
this->Name,
"Design Size Nominal Capacity [W]",
"Autosized Nominal Capacity [W]",
tmpNomCap,
"User-Specified Nominal Capacity [W]",
NomCapUser);
if (state.dataGlobal->DisplayExtraWarnings) {
if ((std::abs(tmpNomCap - NomCapUser) / NomCapUser) > state.dataSize->AutoVsHardSizingThreshold) {
ShowMessage(state, "SizePump: Potential issue with equipment sizing for " + this->Name);
ShowContinueError(state, format("User-Specified Nominal Capacity of {:.2R} [W]", NomCapUser));
ShowContinueError(state, format("differs from Design Size Nominal Capacity of {:.2R} [W]", tmpNomCap));
ShowContinueError(state, format("differs from Autosized Nominal Capacity of {:.2R} [W]", tmpNomCap));
ShowContinueError(state, "This may, or may not, indicate mismatched component sizes.");
ShowContinueError(state, "Verify that the value entered is intended and is consistent with other components.");
}
Expand Down
Loading