-
Notifications
You must be signed in to change notification settings - Fork 27
GeoH2: Arps decline curve #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kbrunik
wants to merge
22
commits into
NatLabRockies:develop
Choose a base branch
from
kbrunik:decline_curves
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
3e49221
WIP arps decline curve
kbrunik fbee5ba
update decline curve
kbrunik db2aa10
update geoh2 and docstring
kbrunik 18c0dc9
update test
kbrunik 0567f10
Merge branch 'develop' into decline_curves
kbrunik a7573f4
update to be percent
kbrunik 02e5145
update documentation
kbrunik 9b590cd
Merge branch 'decline_curves' of https://github.com/kbrunik/H2Integra…
kbrunik ee1b17a
Merge branch 'develop' into decline_curves
kbrunik 9f4bdac
fix changelog
kbrunik 0eb034d
Merge branch 'develop' into decline_curves
kbrunik ee5fddf
Merge branch 'develop' into decline_curves
kbrunik 0a6b686
Update h2integrate/converters/hydrogen/geologic/simple_natural_geoh2.py
kbrunik b77ba18
Update h2integrate/converters/hydrogen/geologic/simple_natural_geoh2.py
kbrunik 259cbbf
precommit fix
kbrunik e636fee
placeholder fix for lifetime simulation
kbrunik b97f419
Merge branch 'develop' into decline_curves
kbrunik 6832828
Merge branch 'develop' into decline_curves
kbrunik d14be4b
Merge branch 'develop' into decline_curves
kbrunik 6d59700
fix failing test units
kbrunik d209da8
Merge branch 'develop' into decline_curves
johnjasa 098bb4c
Merge branch 'develop' into decline_curves
kbrunik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to suggest a couple changes here to temporarily fix the problem of not having declining production over the years. This will make
total_hydrogen_producedbe based off of the average lifetime flow, rather than the production over the first yearThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I made those fixes you suggest and changes the simulation length (8760 to use an average of the lifetime flow for the values for the first year). I'll add context to issue #475