Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
88 commits
Select commit Hold shift + click to select a range
a862e69
added draft of performance model baseclass to set outputs
elenya-grant Jan 20, 2026
bc6a798
updated wind models for standardized outputs
elenya-grant Jan 20, 2026
73edcd0
minor cleanup to wind pysam
elenya-grant Jan 20, 2026
d3d5616
minor cleanup to floris outputs
elenya-grant Jan 20, 2026
3a8ad35
updated outputs of hydroplant
elenya-grant Jan 20, 2026
682959e
updated solar pv models for standardized outputs
elenya-grant Jan 20, 2026
0aef02a
updated solar resource integration tests with updated solar model out…
elenya-grant Jan 20, 2026
8f993d4
added fraction_of_year_simulated attribute to performance baseclass
elenya-grant Jan 20, 2026
a660e21
updated tests for turbine preprocessing tools
elenya-grant Jan 21, 2026
1f9788a
fixed variable naming in test_all_examples for wind and solar
elenya-grant Jan 21, 2026
d1f2387
started updating electrolyzer model outputs
elenya-grant Jan 21, 2026
5db62ae
Merge branch 'develop' into converter_baseclass
johnjasa Jan 21, 2026
f515f5a
Merge branch 'converter_baseclass' of github.com:elenya-grant/GreenHE…
elenya-grant Jan 21, 2026
4227c13
minor bugfix to test_sql_timeseries_to_csv for example 2
elenya-grant Jan 21, 2026
ff3de30
fixed save_case_timeseries_as_csv
elenya-grant Jan 21, 2026
d84c10a
update to sql_to_csv function just in case
elenya-grant Jan 21, 2026
1169376
merged in develop
elenya-grant Jan 21, 2026
40ae090
added attribute check in PerformanceModelBaseClass
elenya-grant Jan 26, 2026
82116bc
typo bugfix in refurb period calc in electrolyzer model
elenya-grant Jan 26, 2026
08f94ef
added test for solar performance baseclass
elenya-grant Jan 27, 2026
7da471c
merged in develop
elenya-grant Jan 27, 2026
8df11d0
added solar test to check that all outputs are set in parent class
elenya-grant Jan 27, 2026
5a38e8f
commented out unused variables in new solar test
elenya-grant Jan 27, 2026
1a51e7b
generalized solar unit test so it can be easily used for other compon…
elenya-grant Jan 27, 2026
3ea3568
updated natural gas plant
elenya-grant Jan 27, 2026
d02ec1b
started updating co2 models
elenya-grant Jan 27, 2026
e868d82
updated grid model
elenya-grant Jan 27, 2026
16a44c5
updated asu model
elenya-grant Jan 27, 2026
d8fda02
updated grid tests
elenya-grant Jan 27, 2026
c32e752
updated desal model
elenya-grant Jan 27, 2026
910a374
updated co2 models and tests
elenya-grant Jan 27, 2026
cca9e4b
updated newest steel models
elenya-grant Jan 27, 2026
b899fae
started updating methanol models but not tested
elenya-grant Jan 27, 2026
e570263
made it so ResizablePerformanceModelBaseClass inherits PerformanceMod…
elenya-grant Jan 27, 2026
ee220e5
updated electrolyzer model and ammonia synloop model
elenya-grant Jan 27, 2026
1b64406
updated simple ammonia model
elenya-grant Jan 27, 2026
496fba0
updated hopp wrapper
elenya-grant Jan 27, 2026
8117034
updated steel.py
elenya-grant Jan 27, 2026
6c7790c
updated iron mine and dri models
elenya-grant Jan 27, 2026
1d0b1ea
updated geoh2 models
elenya-grant Jan 28, 2026
f582c4c
updated battery
elenya-grant Jan 28, 2026
71a1b85
added todo comments to storage models
elenya-grant Jan 28, 2026
be535a3
added unit tests to check that outputs are populated
elenya-grant Jan 28, 2026
b54f32f
working on updating combiners and h2imodel
elenya-grant Jan 28, 2026
8349163
updated electrolyzer so test values dont change and other bugfixes so…
elenya-grant Jan 28, 2026
199c6fd
updated how_to_set_up_an_analysis.md
elenya-grant Jan 28, 2026
d0ac7d8
removed init file from new hydro power test folder
elenya-grant Jan 29, 2026
95fe559
updated remaining failing tests
elenya-grant Jan 29, 2026
9503a1b
updated example 28 and iron_wrapper
elenya-grant Jan 29, 2026
d98ed88
updated capacity factor strings in run_size_modes files
elenya-grant Jan 29, 2026
022f6ca
Merge remote-tracking branch 'h2i_upstream/develop' into converter_ba…
elenya-grant Jan 29, 2026
11d45b2
removed commented out outputs
elenya-grant Jan 29, 2026
01f4124
updated changelog
elenya-grant Jan 29, 2026
9c8dd0e
removed duplicate inheritance of PerformanceModelBaseClass in electro…
elenya-grant Jan 29, 2026
1011686
updated pysam battery outputs
elenya-grant Jan 29, 2026
36c0772
updated annual outputs to properly account for fraction of year simul…
elenya-grant Jan 30, 2026
632d028
moved commodity defn to initialize
elenya-grant Jan 30, 2026
6c9e6ba
updates based on reviewer feedback
elenya-grant Jan 30, 2026
61dddc7
Merge branch 'develop' into converter_baseclass
johnjasa Feb 2, 2026
65b1450
Merge branch 'converter_baseclass_temp' into converter_baseclass
elenya-grant Feb 2, 2026
f36cb4d
merged in develop
elenya-grant Feb 2, 2026
9a770fd
merged in develop
elenya-grant Feb 2, 2026
ed4988c
updated generic storage models and simple controllers
elenya-grant Feb 2, 2026
0cca96d
bugfix in simple_storage_autosizing
elenya-grant Feb 2, 2026
5d0832a
updated test for post-processing timeseries
elenya-grant Feb 3, 2026
0a83daf
added subtest for ex 12
elenya-grant Feb 3, 2026
35ab37d
updated ex 12 test values
elenya-grant Feb 3, 2026
16b54d8
Merge remote-tracking branch 'h2i_upstream/develop' into converter_ba…
elenya-grant Feb 3, 2026
6bfdb07
removed commented out code
elenya-grant Feb 3, 2026
9976fcc
updated changelog
elenya-grant Feb 3, 2026
2ac03d2
added some comments to generic storage performance models
elenya-grant Feb 3, 2026
6221d3e
added more inline and docstring comments
elenya-grant Feb 3, 2026
fe991ae
Merge branch 'develop' into converter_baseclass_storage
johnjasa Feb 3, 2026
cbf40b5
Merge branch 'develop' into converter_baseclass_storage
johnjasa Feb 5, 2026
4804f8b
Minor refactoring changes for clarity
johnjasa Feb 5, 2026
48a20e4
updated docstring in generic storage
elenya-grant Feb 6, 2026
f80224f
Merge branch 'converter_baseclass_storage' of github.com:elenya-grant…
elenya-grant Feb 6, 2026
078874c
updated variable name in simple storage autosizing
elenya-grant Feb 6, 2026
c234212
merged in changelog
elenya-grant Feb 10, 2026
746455c
added charge rate and capacity inputs to simple generic storage
elenya-grant Feb 10, 2026
ef819ea
removed capacity as input to simple_generic_storage
elenya-grant Feb 10, 2026
06fe093
merged test_sql_timeseries_to_csv
elenya-grant Feb 12, 2026
ed175c9
update config names for commodity_name, commodity_units and commodity…
elenya-grant Feb 12, 2026
f378412
updated ex 9
elenya-grant Feb 12, 2026
8f6fc75
minor updates based on feedback
elenya-grant Feb 12, 2026
896783a
updated changelog
elenya-grant Feb 12, 2026
11d5b1e
updated inline comment in simple_generic_storage
elenya-grant Feb 13, 2026
1aedc88
Merge remote-tracking branch 'h2i_upstream/develop' into converter_ba…
elenya-grant Feb 13, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you need to backmerge from develop

Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- Added linearized hydrogen fuel cell model
- Added load following optimization dispatch
- Added simple dispatch calculations to `StorageAutoSizingModel`

## 0.6 [February 10, 2026]

Expand Down
13 changes: 6 additions & 7 deletions examples/01_onshore_steel_mn/tech_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ technologies:
commodity: "electricity"
commodity_units: "kW"
dispatch_rule_parameters:
commodity_name: "electricity"
commodity_storage_units: "kW"
commodity: "electricity"
commodity_rate_units: "kW"

battery:
dispatch_rule_set:
Expand All @@ -81,8 +81,8 @@ technologies:
model: "ATBBatteryCostModel"
model_inputs:
shared_parameters:
commodity_name: "electricity"
commodity_storage_units: "kW"
commodity: "electricity"
commodity_rate_units: "kW"
max_charge_rate: 375740.4 #kW
max_capacity: 375745.2 #kWh
n_control_window: 24
Expand All @@ -96,7 +96,6 @@ technologies:
chemistry: "LFPGraphite"
cost_parameters:
cost_year: 2019
commodity_units: "kW"
energy_capex: 310 # $/kWh from 2024 ATB year 2025
power_capex: 311 # $/kW from 2024 ATB year 2025
opex_fraction: 0.024999840573439444
Expand Down Expand Up @@ -134,8 +133,8 @@ technologies:
model: "LinedRockCavernStorageCostModel"
model_inputs:
shared_parameters:
commodity_name: "hydrogen"
commodity_units: "kg/h"
commodity: "hydrogen"
commodity_rate_units: "kg/h"
cost_parameters:
# since the storage is being auto-sized by the performance model,
# we set the sizing mode to 'auto' rather than defining the capacities
Expand Down
13 changes: 6 additions & 7 deletions examples/02_texas_ammonia/tech_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ technologies:
commodity: "electricity"
commodity_units: "kW"
dispatch_rule_parameters:
commodity_name: "electricity"
commodity_storage_units: "kW"
commodity: "electricity"
commodity_rate_units: "kW"
battery:
dispatch_rule_set:
model: "PyomoRuleStorageBaseclass"
Expand All @@ -79,8 +79,8 @@ technologies:
model: "ATBBatteryCostModel"
model_inputs:
shared_parameters:
commodity_name: "electricity"
commodity_storage_units: "kW"
commodity: "electricity"
commodity_rate_units: "kW"
max_charge_rate: 96.0 #kW
max_capacity: 96.0 #kWh
n_control_window: 24
Expand All @@ -94,7 +94,6 @@ technologies:
chemistry: "LFPGraphite"
cost_parameters:
cost_year: 2019
commodity_units: "kW"
energy_capex: 310 # $/kWh from 2024 ATB year 2025
power_capex: 311 # $/kW from 2024 ATB year 2025
opex_fraction: 0.025
Expand Down Expand Up @@ -133,8 +132,8 @@ technologies:
model: "SaltCavernStorageCostModel"
model_inputs:
shared_parameters:
commodity_name: "hydrogen"
commodity_units: "kg/h"
commodity: "hydrogen"
commodity_rate_units: "kg/h"
cost_parameters:
# since the storage is being auto-sized by the performance model,
# we set the sizing mode to 'auto' rather than defining the capacities
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ technologies:
model: "DemandOpenLoopStorageController"
model_inputs:
shared_parameters:
commodity_name: "hydrogen"
commodity_units: "kg/h"
commodity: "hydrogen"
commodity_rate_units: "kg/h"
max_charge_rate: 50000.0 # kg/time step
max_capacity: 103701.401563086 # kg
control_parameters:
Expand Down Expand Up @@ -135,8 +135,8 @@ technologies:
model: "DemandOpenLoopStorageController"
model_inputs:
shared_parameters:
commodity_name: "co2"
commodity_units: "kg/h"
commodity: "co2"
commodity_rate_units: "kg/h"
max_charge_rate: 50000.0 # kg/time step
max_capacity: 961456.376748904 # kg
control_parameters:
Expand Down
13 changes: 6 additions & 7 deletions examples/09_co2/direct_ocean_capture/tech_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ technologies:
enable_caching: True
hopp_config: !include tech_inputs/hopp_config.yaml
dispatch_rule_parameters:
commodity_name: "electricity"
commodity_storage_units: "kW"
commodity: "electricity"
commodity_rate_units: "kW"
wind:
performance_model:
model: "FlorisWindPlantPerformanceModel"
Expand Down Expand Up @@ -59,8 +59,8 @@ technologies:
commodity: "electricity"
commodity_units: "kW"
dispatch_rule_parameters:
commodity_name: "electricity"
commodity_storage_units: "kW"
commodity: "electricity"
commodity_rate_units: "kW"
battery:
dispatch_rule_set:
model: "PyomoRuleStorageBaseclass"
Expand All @@ -72,8 +72,8 @@ technologies:
model: "ATBBatteryCostModel"
model_inputs:
shared_parameters:
commodity_name: "electricity"
commodity_storage_units: "kW"
commodity: "electricity"
commodity_rate_units: "kW"
max_charge_rate: 50000 #kW
max_capacity: 200000 #kWh
n_control_window: 24
Expand All @@ -87,7 +87,6 @@ technologies:
chemistry: "LFPGraphite"
cost_parameters:
cost_year: 2022
commodity_units: "kW"
energy_capex: 246 # $/kWh from 2024 ATB year 2025
power_capex: 317 # $/kW from 2024 ATB year 2025
opex_fraction: 0.02536510376633359
Expand Down
8 changes: 4 additions & 4 deletions examples/09_co2/ocean_alkalinity_enhancement/tech_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ technologies:
opex_per_kW_per_year: 72
cost_year: 2022
dispatch_rule_parameters:
commodity_name: "electricity"
commodity_storage_units: "kW"
commodity: "electricity"
commodity_rate_units: "kW"


battery:
Expand All @@ -49,8 +49,8 @@ technologies:
model: "ATBBatteryCostModel"
model_inputs:
shared_parameters:
commodity_name: "electricity"
commodity_storage_units: "kW"
commodity: "electricity"
commodity_rate_units: "kW"
max_charge_rate: 50000 #kW
max_capacity: 200000 #kWh
n_control_window: 24
Expand Down
13 changes: 6 additions & 7 deletions examples/12_ammonia_synloop/tech_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ technologies:
commodity: "electricity"
commodity_units: "kW"
dispatch_rule_parameters:
commodity_name: "electricity"
commodity_storage_units: "kW"
commodity: "electricity"
commodity_rate_units: "kW"
battery:
dispatch_rule_set:
model: "PyomoRuleStorageBaseclass"
Expand All @@ -79,8 +79,8 @@ technologies:
model: "ATBBatteryCostModel"
model_inputs:
shared_parameters:
commodity_name: "electricity"
commodity_storage_units: "kW"
commodity: "electricity"
commodity_rate_units: "kW"
max_charge_rate: 96.0 #kW
max_capacity: 96.0 #kWh
n_control_window: 24
Expand All @@ -94,7 +94,6 @@ technologies:
chemistry: "LFPGraphite"
cost_parameters:
cost_year: 2019
commodity_units: "kW"
energy_capex: 310 # $/kWh from 2024 ATB year 2025
power_capex: 311 # $/kW from 2024 ATB year 2025
opex_fraction: 0.025
Expand Down Expand Up @@ -133,8 +132,8 @@ technologies:
model: "SaltCavernStorageCostModel"
model_inputs:
shared_parameters:
commodity_name: "hydrogen"
commodity_units: "kg/h"
commodity: "hydrogen"
commodity_rate_units: "kg/h"
cost_parameters:
# since the storage is being auto-sized by the performance model,
# we set the sizing mode to 'auto' rather than defining the capacities
Expand Down
6 changes: 3 additions & 3 deletions examples/14_wind_hydrogen_dispatch/inputs/tech_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ technologies:
model: "DemandOpenLoopStorageController"
model_inputs:
shared_parameters:
commodity_name: "hydrogen"
commodity_units: "kg/h"
commodity: "hydrogen"
commodity_rate_units: "kg/h"
max_charge_rate: 12446.00729773 # kg/time step
max_capacity: 2987042.0 # kg
control_parameters:
Expand All @@ -71,4 +71,4 @@ technologies:
max_discharge_rate: 12446.00729773 # kg/time step
charge_efficiency: 1.0 # percent as decimal
discharge_efficiency: 1.0 # percent as decimal
demand_profile: 5000 # constant demand of 5000 kg per hour (see commodity_units)
demand_profile: 5000 # constant demand of 5000 kg per hour (see commodity_rate_units)
4 changes: 2 additions & 2 deletions examples/16_natural_gas/tech_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ technologies:
model: "DemandOpenLoopStorageController"
model_inputs:
shared_parameters:
commodity_name: "electricity"
commodity_units: "kW"
commodity: "electricity"
commodity_rate_units: "kW"
max_charge_rate: 25000.0 # kW/time step, 25 MW
max_capacity: 200000.0 # kWh, 200 MWh
control_parameters:
Expand Down
9 changes: 4 additions & 5 deletions examples/18_pyomo_heuristic_dispatch/tech_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ technologies:
opex_per_kW_per_year: 45
cost_year: 2019
dispatch_rule_parameters:
commodity_name: "electricity"
commodity_storage_units: "kW"
commodity: "electricity"
commodity_rate_units: "kW"
battery:
dispatch_rule_set:
model: "PyomoRuleStorageBaseclass"
Expand All @@ -45,8 +45,8 @@ technologies:
model: "ATBBatteryCostModel"
model_inputs:
shared_parameters:
commodity_name: "electricity"
commodity_storage_units: "kW"
commodity: "electricity"
commodity_rate_units: "kW"
max_charge_rate: 100000
max_capacity: 500000
n_control_window: 24
Expand All @@ -60,7 +60,6 @@ technologies:
chemistry: "LFPGraphite"
cost_parameters:
cost_year: 2022
commodity_units: "kW"
energy_capex: 310 # $/kWh from 2024 ATB year 2025
power_capex: 311 # $/kW from 2024 ATB year 2025
opex_fraction: 0.25 # 0.25% of capex per year from 2024 ATB
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ technologies:
opex_per_kW_per_year: 45
cost_year: 2019
dispatch_rule_parameters:
commodity_name: "electricity"
commodity_storage_units: "kW"
commodity: "electricity"
commodity_rate_units: "kW"
battery:
dispatch_rule_set:
model: "PyomoRuleStorageBaseclass"
Expand All @@ -48,8 +48,8 @@ technologies:
model: "ATBBatteryCostModel"
model_inputs:
shared_parameters:
commodity_name: "electricity"
commodity_storage_units: "kW"
commodity: "electricity"
commodity_rate_units: "kW"
max_charge_rate: 100000
max_capacity: 500000
n_control_window: 24
Expand Down
4 changes: 2 additions & 2 deletions examples/19_simple_dispatch/tech_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ technologies:
model: "DemandOpenLoopStorageController"
model_inputs:
shared_parameters:
commodity_name: "electricity"
commodity_units: "kW"
commodity: "electricity"
commodity_rate_units: "kW"
max_charge_rate: 5000.0 # kW
max_capacity: 30000.0 # kWh
control_parameters:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ technologies:
model: FlexibleDemandOpenLoopConverterController
model_inputs:
control_parameters:
commodity_name: electricity
commodity_units: kW
commodity: electricity
commodity_rate_units: kW
rated_demand: 100000
demand_profile: 100000 #100 MW
turndown_ratio: 0.5
Expand Down
13 changes: 0 additions & 13 deletions examples/23_solar_wind_ng_demand/plant_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,6 @@ sites:
site:
latitude: 30.6617
longitude: -101.7096
year: 2013

# array of polygons defining boundaries with x/y coords
boundaries: [
{
x: [0.0, 1000.0, 1000.0, 0.0],
y: [0.0, 0.0, 100.0, 1000.0],
},
{
x: [2000.0, 2500.0, 2000.0],
y: [2000.0, 2000.0, 2500.0],
}
]

resources:
wind_resource:
Expand Down
4 changes: 2 additions & 2 deletions examples/23_solar_wind_ng_demand/tech_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ technologies:
model: DemandOpenLoopConverterController
model_inputs:
control_parameters:
commodity_name: electricity
commodity_units: kW
commodity: electricity
commodity_rate_units: kW
demand_profile: 100000 #100 MW

combiner:
Expand Down
4 changes: 2 additions & 2 deletions examples/24_solar_battery_grid/tech_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ technologies:
model: "DemandOpenLoopStorageController"
model_inputs:
shared_parameters:
commodity_name: "electricity"
commodity_units: "kW"
commodity: "electricity"
commodity_rate_units: "kW"
max_charge_rate: 25000.0 # kW/time step, 25 MW
max_capacity: 200000.0 # kWh, 200 MWh
control_parameters:
Expand Down
9 changes: 4 additions & 5 deletions examples/27_pyomo_optimized_dispatch/tech_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ technologies:
opex_per_kW_per_year: 45
cost_year: 2019
dispatch_rule_parameters:
commodity_name: "electricity"
commodity_storage_units: "kW"
commodity: "electricity"
commodity_rate_units: "kW"
battery:
dispatch_rule_set:
model: "PyomoRuleStorageBaseclass"
Expand All @@ -49,7 +49,7 @@ technologies:
model: "ATBBatteryCostModel"
model_inputs:
shared_parameters:
commodity_name: "electricity"
commodity: "electricity"
max_charge_rate: 100000
max_capacity: 400000
init_charge_percent: 0.5 # Initial SOC for the storage
Expand All @@ -58,15 +58,14 @@ technologies:
system_commodity_interface_limit: 1e12
charge_efficiency: 0.95 # Charge efficiency of the storage technology
discharge_efficiency: 0.95 # Discharge efficiency of the storage technology
commodity_storage_units: "kW"
commodity_rate_units: "kW"
# rated_demand: 100000 # in kW

performance_parameters:
system_model_source: "pysam"
chemistry: "LFPGraphite"
cost_parameters:
cost_year: 2022
commodity_units: "kW"
energy_capex: 310 # $/kWh from 2024 ATB year 2025
power_capex: 311 # $/kW from 2024 ATB year 2025
opex_fraction: 0.25 # 0.25% of capex per year from 2024 ATB
Expand Down
Loading