-
Notifications
You must be signed in to change notification settings - Fork 27
Standardized Performance Outputs: Generic Storage & Control #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
johnjasa
merged 88 commits into
NatLabRockies:develop
from
elenya-grant:converter_baseclass_storage
Feb 13, 2026
Merged
Changes from all commits
Commits
Show all changes
88 commits
Select commit
Hold shift + click to select a range
a862e69
added draft of performance model baseclass to set outputs
elenya-grant bc6a798
updated wind models for standardized outputs
elenya-grant 73edcd0
minor cleanup to wind pysam
elenya-grant d3d5616
minor cleanup to floris outputs
elenya-grant 3a8ad35
updated outputs of hydroplant
elenya-grant 682959e
updated solar pv models for standardized outputs
elenya-grant 0aef02a
updated solar resource integration tests with updated solar model out…
elenya-grant 8f993d4
added fraction_of_year_simulated attribute to performance baseclass
elenya-grant a660e21
updated tests for turbine preprocessing tools
elenya-grant 1f9788a
fixed variable naming in test_all_examples for wind and solar
elenya-grant d1f2387
started updating electrolyzer model outputs
elenya-grant 5db62ae
Merge branch 'develop' into converter_baseclass
johnjasa f515f5a
Merge branch 'converter_baseclass' of github.com:elenya-grant/GreenHE…
elenya-grant 4227c13
minor bugfix to test_sql_timeseries_to_csv for example 2
elenya-grant ff3de30
fixed save_case_timeseries_as_csv
elenya-grant d84c10a
update to sql_to_csv function just in case
elenya-grant 1169376
merged in develop
elenya-grant 40ae090
added attribute check in PerformanceModelBaseClass
elenya-grant 82116bc
typo bugfix in refurb period calc in electrolyzer model
elenya-grant 08f94ef
added test for solar performance baseclass
elenya-grant 7da471c
merged in develop
elenya-grant 8df11d0
added solar test to check that all outputs are set in parent class
elenya-grant 5a38e8f
commented out unused variables in new solar test
elenya-grant 1a51e7b
generalized solar unit test so it can be easily used for other compon…
elenya-grant 3ea3568
updated natural gas plant
elenya-grant d02ec1b
started updating co2 models
elenya-grant e868d82
updated grid model
elenya-grant 16a44c5
updated asu model
elenya-grant d8fda02
updated grid tests
elenya-grant c32e752
updated desal model
elenya-grant 910a374
updated co2 models and tests
elenya-grant cca9e4b
updated newest steel models
elenya-grant b899fae
started updating methanol models but not tested
elenya-grant e570263
made it so ResizablePerformanceModelBaseClass inherits PerformanceMod…
elenya-grant ee220e5
updated electrolyzer model and ammonia synloop model
elenya-grant 1b64406
updated simple ammonia model
elenya-grant 496fba0
updated hopp wrapper
elenya-grant 8117034
updated steel.py
elenya-grant 6c7790c
updated iron mine and dri models
elenya-grant 1d0b1ea
updated geoh2 models
elenya-grant f582c4c
updated battery
elenya-grant 71a1b85
added todo comments to storage models
elenya-grant be535a3
added unit tests to check that outputs are populated
elenya-grant b54f32f
working on updating combiners and h2imodel
elenya-grant 8349163
updated electrolyzer so test values dont change and other bugfixes so…
elenya-grant 199c6fd
updated how_to_set_up_an_analysis.md
elenya-grant d0ac7d8
removed init file from new hydro power test folder
elenya-grant 95fe559
updated remaining failing tests
elenya-grant 9503a1b
updated example 28 and iron_wrapper
elenya-grant d98ed88
updated capacity factor strings in run_size_modes files
elenya-grant 022f6ca
Merge remote-tracking branch 'h2i_upstream/develop' into converter_ba…
elenya-grant 11d45b2
removed commented out outputs
elenya-grant 01f4124
updated changelog
elenya-grant 9c8dd0e
removed duplicate inheritance of PerformanceModelBaseClass in electro…
elenya-grant 1011686
updated pysam battery outputs
elenya-grant 36c0772
updated annual outputs to properly account for fraction of year simul…
elenya-grant 632d028
moved commodity defn to initialize
elenya-grant 6c9e6ba
updates based on reviewer feedback
elenya-grant 61dddc7
Merge branch 'develop' into converter_baseclass
johnjasa 65b1450
Merge branch 'converter_baseclass_temp' into converter_baseclass
elenya-grant f36cb4d
merged in develop
elenya-grant 9a770fd
merged in develop
elenya-grant ed4988c
updated generic storage models and simple controllers
elenya-grant 0cca96d
bugfix in simple_storage_autosizing
elenya-grant 5d0832a
updated test for post-processing timeseries
elenya-grant 0a83daf
added subtest for ex 12
elenya-grant 35ab37d
updated ex 12 test values
elenya-grant 16b54d8
Merge remote-tracking branch 'h2i_upstream/develop' into converter_ba…
elenya-grant 6bfdb07
removed commented out code
elenya-grant 9976fcc
updated changelog
elenya-grant 2ac03d2
added some comments to generic storage performance models
elenya-grant 6221d3e
added more inline and docstring comments
elenya-grant fe991ae
Merge branch 'develop' into converter_baseclass_storage
johnjasa cbf40b5
Merge branch 'develop' into converter_baseclass_storage
johnjasa 4804f8b
Minor refactoring changes for clarity
johnjasa 48a20e4
updated docstring in generic storage
elenya-grant f80224f
Merge branch 'converter_baseclass_storage' of github.com:elenya-grant…
elenya-grant 078874c
updated variable name in simple storage autosizing
elenya-grant c234212
merged in changelog
elenya-grant 746455c
added charge rate and capacity inputs to simple generic storage
elenya-grant ef819ea
removed capacity as input to simple_generic_storage
elenya-grant 06fe093
merged test_sql_timeseries_to_csv
elenya-grant ed175c9
update config names for commodity_name, commodity_units and commodity…
elenya-grant f378412
updated ex 9
elenya-grant 8f6fc75
minor updates based on feedback
elenya-grant 896783a
updated changelog
elenya-grant 11d5b1e
updated inline comment in simple_generic_storage
elenya-grant 1aedc88
Merge remote-tracking branch 'h2i_upstream/develop' into converter_ba…
elenya-grant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you need to backmerge from develop