Address energy outside of an HVAC season or during unavailable period #2151
Conversation
…riods in defrost, pan, and crankcase ems programs.
joseph-robertson
changed the title
HPXMLtoOpenStudio/resources/hvac.rb
Outdated
| # Don't run crankcase heater during HVAC unavailable period either | ||
| temp_criteria += " && (#{hvac_avail_sensor.name} == 1)" |
There was a problem hiding this comment.
Should this only run when (A) AC and cooling available, and (B) HP and either heating/cooling available?
HPXMLtoOpenStudio/resources/hvac.rb
Outdated
| name: "#{clg_coil.name} crankcase program" | ||
| ) | ||
| program.addLine("Set T_out = #{tout_db_sensor.name}") | ||
| temp_criteria = "If (T_out < #{max_oat_crankcase})" |
There was a problem hiding this comment.
Crankcase heater only operates when the compressor is not running -- how do we incorporate that here?
There was a problem hiding this comment.
1 minus the coil runtime fraction?
There was a problem hiding this comment.
e.g., crankcase_power * (1 - coil_rtf)
You don't incorporate it in the criteria, you incorporate it in the energy use calculation.
| base-hvac-air-to-air-heat-pump-var-speed-pan-heater-none.xml,52.657,52.657,52.657,52.657,0.0,0.0,0.0,0.0,0.0,0.0,13.275,1.067,2.3,0.011,3.764,0.458,10.77,0.0,0.0,4.507,0.0,0.334,0.0,0.0,0.0,0.0,2.074,0.0,0.0,0.284,0.347,1.436,1.529,0.0,2.116,8.384,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0 | ||
| base-hvac-air-to-air-heat-pump-var-speed-research-features.xml,53.164,53.164,53.164,53.164,0.0,0.0,0.0,0.0,0.0,0.0,13.643,1.36,2.14,0.017,3.764,0.46,10.771,0.0,0.0,4.507,0.0,0.334,0.0,0.0,0.0,0.0,2.072,0.0,0.0,0.284,0.347,1.436,1.529,0.0,2.116,8.384,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0 | ||
| base-hvac-air-to-air-heat-pump-var-speed.xml,53.503,53.503,53.503,53.503,0.0,0.0,0.0,0.0,0.0,0.0,14.121,1.067,2.3,0.011,3.764,0.458,10.77,0.0,0.0,4.507,0.0,0.334,0.0,0.0,0.0,0.0,2.074,0.0,0.0,0.284,0.347,1.436,1.529,0.0,2.116,8.384,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0 | ||
| base-hvac-air-to-air-heat-pump-2-speed.xml,52.895,52.895,52.895,52.895,0.0,0.0,0.0,0.0,0.0,0.0,11.775,1.245,3.477,0.071,4.057,0.489,10.77,0.0,0.0,4.507,0.0,0.334,0.0,0.0,0.0,0.0,2.074,0.0,0.0,0.284,0.347,1.436,1.529,0.0,2.116,8.384,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0 |
There was a problem hiding this comment.
I'm struggling to understand why the new crankcase EMS program shows agreement for 1-speed ASHP, but not multispeed ASHP. See the following, where the original crankcase output variable is reported vs the EMS power * (1 - RTF) calculation. Is there something other than RTF that E+ uses for determining whether the compressor is running or not?
There was a problem hiding this comment.
This definitely looks related: NatLabRockies/EnergyPlus#10052
There was a problem hiding this comment.
The above issue is somewhat related, but not the cause of the discrepancy. This commit should bring E+ crankcase and EMS crankcase into alignment: ecdc565
|
👋 Hi, I'm an automated AI code review bot. I ran some checks on this PR and found 1 point that might be worth attention (could be false positives, please use your judgment):
If you find these suggestions disruptive, you can reply "stop" , and I'll automatically skip this repository in the future. |
Pull Request Description
Closes #2149.
Checklist
Not all may apply:
EPvalidator.sch) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run