Skip to content

Add module-level R_GAS constant value to diffusion.py#313

Merged
RDaxini merged 4 commits intodevelopmentfrom
rgas
Feb 4, 2026
Merged

Add module-level R_GAS constant value to diffusion.py#313
RDaxini merged 4 commits intodevelopmentfrom
rgas

Conversation

@RDaxini
Copy link
Collaborator

@RDaxini RDaxini commented Jan 26, 2026

Describe your changes

Replace hard-coded magic number 0.0083144626 with a module-level R_GAS (gas constant) value

Issue ticket number and link

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • Code changes are covered by tests.
  • Code changes have been evaluated for compatibility/integration with Scenario analysis (for future PRs)
  • Code changes have been evaluated for compatibility/integration with geospatial autotemplating (for future PRs)
  • New functions added to init.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • What's new changelog has been updated in the docs

@RDaxini RDaxini added enhancement New feature or request Clarity for users Things that help the user implement the code more easily. labels Jan 26, 2026
@RDaxini RDaxini changed the base branch from main to development February 2, 2026 23:09
@RDaxini RDaxini marked this pull request as draft February 3, 2026 18:27
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.72%. Comparing base (51172fd) to head (5b76b1a).
⚠️ Report is 459 commits behind head on development.

Files with missing lines Patch % Lines
pvdeg/diffusion.py 55.55% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #313      +/-   ##
===============================================
+ Coverage        71.66%   74.72%   +3.06%     
===============================================
  Files               40       41       +1     
  Lines             4524     4823     +299     
===============================================
+ Hits              3242     3604     +362     
+ Misses            1282     1219      -63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RDaxini RDaxini marked this pull request as ready for review February 3, 2026 20:42
@RDaxini RDaxini marked this pull request as draft February 3, 2026 20:49
@RDaxini RDaxini marked this pull request as ready for review February 3, 2026 20:49
Copy link
Collaborator

@martin-springer martin-springer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for cleaning this up!

@RDaxini RDaxini merged commit f049498 into development Feb 4, 2026
18 checks passed
@RDaxini RDaxini deleted the rgas branch February 4, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Clarity for users Things that help the user implement the code more easily. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants