Conversation
addJob() to accept multiple degradation jobs (functions)addJob() to accept multiple degradation jobs (functions)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
==========================================
+ Coverage 74.72% 74.97% +0.24%
==========================================
Files 41 41
Lines 4823 4867 +44
==========================================
+ Hits 3604 3649 +45
+ Misses 1219 1218 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
checks single job, tuple (job, kwargs), and list of multiple jobs/kwargs
addJob() to accept multiple degradation jobs (functions)addJob() to accept multiple degradation jobs (functions)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Basic principle of this change:
extracts the original "adding" component to a helper function, creates a modified addJob function loops over the helper, and includes checks for compatibility (raises errors otherwise)
other notes:
func_kwargargument is removed. now,functakes both the function(s) and the(ir) respective argument(s)Issue ticket number and link
Fixes #181
Type of change
Please delete options that are not relevant.
Checklist before requesting a review