Skip to content

[WIP] Change NREL to NLR, clean up tutorials folder#319

Open
shirubana wants to merge 10 commits intodevelopmentfrom
rescue-bad-push
Open

[WIP] Change NREL to NLR, clean up tutorials folder#319
shirubana wants to merge 10 commits intodevelopmentfrom
rescue-bad-push

Conversation

@shirubana
Copy link
Member

@shirubana shirubana commented Mar 6, 2026

[WIP] - As of 3/12/2026, kestrel.hpc.nrel.gov hasn't been updated to kestrel.hpc.nlr.gov. Once that change is happening, we'll move this PR forward.

Describe your changes

More thorough update of NREL to NLR, including HPC addresses and functions, tutorials, the 500+ mentions of the nlr.developer API URL, github URLs, NSRDB url, and packages like NLR-rex.
Note NREL-pysam has not migrated yet and is planned migration on April.

Issue ticket number and link

Type of change

Please delete options that are not relevant.

  • [?] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [?] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • [?] I have performed a self-review of my code
  • Code changes are covered by tests.
  • Code changes have been evaluated for compatibility/integration with Scenario analysis (for future PRs)
  • Code changes have been evaluated for compatibility/integration with geospatial autotemplating (for future PRs)
  • New functions added to init.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • What's new changelog has been updated in the docs

04_geospatial moved its two files into 05_geospatial and to tools previously, but was never deleted. removing it now.
05_advance folder was moved to 06_advanced but left there. removing.
most of these scripts had their journal (and script) moved to 05_geospatial and other foldres like tools. I accounted for all of these except "local_scenario" but that seemed like a beggining of a script that got developed into something else.
@shirubana shirubana requested a review from RDaxini March 6, 2026 21:07
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.70%. Comparing base (51172fd) to head (deac2dc).
⚠️ Report is 490 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #319      +/-   ##
===============================================
+ Coverage        71.66%   74.70%   +3.04%     
===============================================
  Files               40       41       +1     
  Lines             4524     4823     +299     
===============================================
+ Hits              3242     3603     +361     
+ Misses            1282     1220      -62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RDaxini RDaxini requested a review from martin-springer March 12, 2026 19:56
Copy link
Collaborator

@RDaxini RDaxini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to keep the .py files for the notebooks. Was their deletion in error?

Had a chat with and requested a review from Martin as there might also be issues with the main branch commits but I don't have access for modifications there.

Thanks for working on the name change though!

@shirubana
Copy link
Member Author

We are keeping the .py, I just deleted ones that were not properly placed

@martin-springer martin-springer changed the base branch from main to development March 12, 2026 21:14
martin-springer and others added 5 commits March 12, 2026 17:25
most of these scripts had their journal (and script) moved to 05_geospatial and other foldres like tools. I accounted for all of these except "local_scenario" but that seemed like a beggining of a script that got developed into something else.
@martin-springer martin-springer changed the title Rescue bad push [WIP] Rescue bad push Mar 12, 2026
@martin-springer martin-springer changed the title [WIP] Rescue bad push [WIP] Change NREL to NLR, clean up tutorials folder Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants