Repository navigation
fix small bugs, tidy docs, commit uv.lock - #21
Merged
Merged
Conversation
bugs:
- PVEnv.reset() returned None
- to_scaled never warned when x was above high (operator precedence)
- FiveZoneROMEnv.step_reward counted upper violations twice, lower never
- building env assigned self.model instead of self.models
- get_bus_voltage_by_name replaced every occurrence of the phase letter
- energy storage obs label typo (stage_of_charge -> state_of_charge)
- energy storage used Timedelta.seconds instead of total_seconds()
- MultiAgentEnv ended episodes one step early (max_episode_steps=250 ran 249)
- reward_structure={"alpha": ...} was silently swallowed by **kwargs; alpha
is now a real FiveZoneROMThermalEnergyEnv arg (default 0.2, same as before)
and the dead config is removed from the scenario and notebook
cleanup: run_command -> Command (kills ~2.5k deprecation warnings in tests),
print -> logger, drop duplicate/no-op abstractmethods, mutable defaults, and
dead code.
docs: readme install/test steps, examples index, typos, pyproject metadata,
ci comments.
adds tests/test_regressions.py covering each fix.
Co-Authored-By: Claude <noreply@anthropic.com>
macos runners are shared across the whole org with a much lower concurrency cap, so jobs were sitting in the queue. nothing here needs macos. Co-Authored-By: Claude <noreply@anthropic.com>
davebiagioni
added a commit
that referenced
this pull request
Nov 11, 2026
# Conflicts: # .github/workflows/main.yml
Co-Authored-By: Claude <noreply@anthropic.com>
tests were written from signatures and docstrings only, without reading the implementation. where the code disagrees with its docs the test is kept and marked xfail(strict=True) with the discrepancy in the reason. Co-authored-by: davebiagioni <davebiagioni@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some upkeep while poking around the repo. mostly small, each bug has a regression test in
tests/test_regressions.py(6 of the 7 fail on main).bugs
high(operator precedence)self.modelinstead ofself.models(harmless only because updates are in place)str.replaceswapped every copy of the phase letter, not just the suffixstage_of_charge;Timedelta.secondsinstead oftotal_seconds()reward_structure={"alpha": ...}in configs was silently eaten by**kwargsbehavior changes worth knowing about
max_episode_steps=250now actually runs 250 steps, not 249. fig3 and the rllib example setrollout_fragment_length = env.max_episode_steps, so this lines them up the way the rllib readme says it should. fig3 won't reproduce to the exact step.reward_structureconfig from the heterogeneous scenario and the list-interface notebook rather than honoring it, since honoring it would quietly flip fig3's reward from the 0.2 it trained with to 0.0.cleanup
run_command->Command. test warnings go from ~2,580 to 0.reward_transformand no-op@abstractmethods, mutable default args, unused imports, dead code.docs
pyteststypo, repo dir casing, author name typoexamples/README.mdnow actually indexes the notebooks and marl examplesuv.lockso ci installs are reproduciblenot in here
envs still return the old 4-tuple from
step()despite the gymnasium migration. that's an api change, better as its own pr.testing
uv run pytest tests/— 16 passeduv run pytest --nbmake examples/envs— 9 passed