Change "facing west" criterion to allow small uncertainty in sazm#62
Open
kandersolar wants to merge 1 commit intoNatLabRockies:mainfrom
Open
Change "facing west" criterion to allow small uncertainty in sazm#62kandersolar wants to merge 1 commit intoNatLabRockies:mainfrom
sazm#62kandersolar wants to merge 1 commit intoNatLabRockies:mainfrom
Conversation
Member
Author
|
Test failure seems unrelated. |
Contributor
|
See my comment - I think checking the sign of sine is a more robust solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #61
Using the same reproducer as #61 with this branch, the swapping is gone:
Disclaimer: I'm not very familiar at all with bifacialvf and have not evaluated the suitability of this fix beyond making the above plot.