Script to compute nonpremixed flamelets using Cantera#29
Merged
baperry2 merged 5 commits intodevelopmentfrom Jan 6, 2026
Merged
Script to compute nonpremixed flamelets using Cantera#29baperry2 merged 5 commits intodevelopmentfrom
baperry2 merged 5 commits intodevelopmentfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new script for computing nonpremixed counterflow flamelets using Cantera and refactors the existing premixed flamelet script to use shared helper functions. The implementation includes S-curve traversal capabilities for extinction analysis.
Key changes:
- New nonpremixed flamelet computation script with strain rate sweeping and S-curve analysis
- Refactoring of premixed flamelet script to use shared
cantera_helpersmodule - Updated Cantera dependency to >= 3.2.0 and added func-timeout dependency
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| run_scripts/cantera/compute_premixed_flamelets.py | Refactored to use helper functions save_flame_csv and save_table_metadata from new cantera_helpers module |
| run_scripts/cantera/compute_nonpremixed_flamelets.py | New script implementing counterflow diffusion flame solver with S-curve traversal for extinction analysis |
| run_scripts/cantera/compute_nonpremixed_flamelets.toml | Configuration file for nonpremixed flamelet computations with physical conditions, numerics, and S-curve options |
| pyproject.toml | Updated Cantera version requirement to 3.2.0 and added func-timeout dependency |
| docs/library-api.rst | Added reference to new cantera_helpers utility module |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.