Skip to content

save Zmix in nonpremixed and do better at saving extinction#31

Merged
baperry2 merged 2 commits intodevelopmentfrom
improve-nonp
Jan 12, 2026
Merged

save Zmix in nonpremixed and do better at saving extinction#31
baperry2 merged 2 commits intodevelopmentfrom
improve-nonp

Conversation

@baperry2
Copy link
Collaborator

@baperry2 baperry2 commented Jan 9, 2026

For nonpremixed flamelets we need to save the mixture fraction as part of the flamelet data.

Also, if the flame solve fails hen approaching extinction, do a new solve at high strain rate automatically to get an extinct flamelet.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@baperry2 baperry2 requested a review from Copilot January 10, 2026 00:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

)
flame = get_new_flame()
update_flame(flame, ext_alpha)
flame.solve()
Copy link

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flame.solve() call here lacks error handling. If this solve fails, it will raise an unhandled exception and crash the program. Consider wrapping this in a try-except block or using func_timeout like the other solve calls in this file.

Suggested change
flame.solve()
try:
flame.solve()
except FunctionTimedOut as exc:
print(
f"rank {rank}: Extinct flame solve timed out at alpha = {ext_alpha}: {exc}",
flush=True,
)
solve_failed = True
break
except Exception as exc:
print(
f"rank {rank}: Extinct flame solve failed at alpha = {ext_alpha}: {exc}",
flush=True,
)
solve_failed = True
break

Copilot uses AI. Check for mistakes.
# strain rate increase is reached, save the last, non-burning, solution
# to the output file and break the loop

# if last solve failed, recompute with vhigh strain to get extinct flame
Copy link

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment contains a typo: "vhigh" should be "very high" or "v. high".

Suggested change
# if last solve failed, recompute with vhigh strain to get extinct flame
# if last solve failed, recompute with very high strain to get extinct flame

Copilot uses AI. Check for mistakes.
@baperry2 baperry2 merged commit 5a44583 into development Jan 12, 2026
17 checks passed
@baperry2 baperry2 deleted the improve-nonp branch January 12, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant