Conversation
…essing automation
…esale electricity price input data
There was a problem hiding this comment.
Pull Request Overview
This PR updates the dGen input data with new battery technology performance and pricing information from ATB24 (Advanced Technology Baseline 2024), replacing older SunLamp17 data. The update includes processing code to facilitate future input data updates.
- Replaces legacy SunLamp17 battery performance data with three ATB24 scenarios (advanced, moderate, conservative)
- Adds comprehensive battery pricing data for all three ATB24 scenarios with detailed cost breakdowns
- Includes a metadata file documenting carbon intensity units
Reviewed Changes
Copilot reviewed 8 out of 151 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| carbon_intensities-checkpoint.txt | Adds units documentation for carbon intensity data |
| batt_tech_performance_atb24_*.csv | Three new battery performance files with efficiency and lifetime data for different technology scenarios |
| batt_tech_performance_SunLamp17.csv | Removes outdated SunLamp17 battery performance data |
| batt_price_atb24_*.csv | Three new battery pricing files with comprehensive cost data for different technology scenarios |
| @@ -0,0 +1 @@ | |||
| Units: tons of CO2 per kWh of electricity No newline at end of file | |||
There was a problem hiding this comment.
Jupyter notebook checkpoint files should not be committed to version control. These are automatically generated files that can cause merge conflicts and clutter the repository.
| Units: tons of CO2 per kWh of electricity |
…ket Case is being used for the financial input data
…o input_data_updates
…and R&D financial scenarios
…y used formatting in dGen
…ository for input data updates
… changes on the solar PV ITC from the OBBA
michaelavs
left a comment
There was a problem hiding this comment.
I am going to go ahead and merge this today as is, but I believe there will be necessary code and CI updates for full compatibility and coverage:
-
The new load growth datasets require a couple code updates in order to be pulled locally rather than from the database. The database currently attaches the
county_idvariable onto the returnedload_growth_df, andcounty_idis used in theapply_load_growthfunction to merge the load data onto the agent data. For now, I left the 'load growth scenario' in the scenario file as pulling from the 2019 table as it was from previous years. I will open an issue to go into more depth on this and we can address it in the future. -
We will need to update the CI routine(s) to ensure the pipeline is using the new datasets and input scenario sheet. I will open an issue for us to address in the future.
The dGen input data is updated, and processing code is added to facilitate future input data updates.