Skip to content

Input data updates#74

Merged
michaelavs merged 44 commits intomasterfrom
input_data_updates
Feb 17, 2026
Merged

Input data updates#74
michaelavs merged 44 commits intomasterfrom
input_data_updates

Conversation

@prateek-joshi-31
Copy link
Collaborator

The dGen input data is updated, and processing code is added to facilitate future input data updates.

Joshi and others added 25 commits April 14, 2025 15:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the dGen input data with new battery technology performance and pricing information from ATB24 (Advanced Technology Baseline 2024), replacing older SunLamp17 data. The update includes processing code to facilitate future input data updates.

  • Replaces legacy SunLamp17 battery performance data with three ATB24 scenarios (advanced, moderate, conservative)
  • Adds comprehensive battery pricing data for all three ATB24 scenarios with detailed cost breakdowns
  • Includes a metadata file documenting carbon intensity units

Reviewed Changes

Copilot reviewed 8 out of 151 changed files in this pull request and generated 1 comment.

File Description
carbon_intensities-checkpoint.txt Adds units documentation for carbon intensity data
batt_tech_performance_atb24_*.csv Three new battery performance files with efficiency and lifetime data for different technology scenarios
batt_tech_performance_SunLamp17.csv Removes outdated SunLamp17 battery performance data
batt_price_atb24_*.csv Three new battery pricing files with comprehensive cost data for different technology scenarios

@@ -0,0 +1 @@
Units: tons of CO2 per kWh of electricity No newline at end of file
Copy link

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jupyter notebook checkpoint files should not be committed to version control. These are automatically generated files that can cause merge conflicts and clutter the repository.

Suggested change
Units: tons of CO2 per kWh of electricity

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

@michaelavs michaelavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to go ahead and merge this today as is, but I believe there will be necessary code and CI updates for full compatibility and coverage:

  1. The new load growth datasets require a couple code updates in order to be pulled locally rather than from the database. The database currently attaches the county_id variable onto the returned load_growth_df, and county_id is used in the apply_load_growth function to merge the load data onto the agent data. For now, I left the 'load growth scenario' in the scenario file as pulling from the 2019 table as it was from previous years. I will open an issue to go into more depth on this and we can address it in the future.

  2. We will need to update the CI routine(s) to ensure the pipeline is using the new datasets and input scenario sheet. I will open an issue for us to address in the future.

@michaelavs michaelavs merged commit beb0df1 into master Feb 17, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments