Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #192 by adding a new example demonstrating the WindFarmSCADAPower component, which allows simulating wind farms using SCADA power data instead of wind speed data.
Key Changes
- New example directory
00b_wind_farm_scada_powerwith runscript, configuration, plotting, and documentation - Enhanced input generation script to produce SCADA power data alongside wind speed data
- Updated utility functions to track the new
scada_input.ftrfile
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
hercules/utilities_examples.py |
Updated documentation and file tracking to include new scada_input.ftr file |
examples/inputs/00_generate_wind_history_small.py |
Extended to generate turbine power data using cubic wind speed approximation |
examples/00b_wind_farm_scada_power/hercules_input.yaml |
Configuration file for WindFarmSCADAPower example |
examples/00b_wind_farm_scada_power/hercules_runscript.py |
Main simulation script with controller that toggles turbine 0 power setpoint |
examples/00b_wind_farm_scada_power/plot_outputs.py |
Plotting script to visualize simulation outputs |
examples/00b_wind_farm_scada_power/README.md |
Documentation describing the example setup and usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
genevievestarke
approved these changes
Jan 16, 2026
Collaborator
genevievestarke
left a comment
There was a problem hiding this comment.
This looks good to me! I ran it locally and all looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to address #192. Based on that issue what is needed is:
WindFarmSCADAPowerWindFarmSCADAPower(although note this might not be necessary, pending discussion in WindFarmSCADAPower class testing and examples #192)WindFarmSCADAPower(although note this might not be necessary, pending discussion in WindFarmSCADAPower class testing and examples #192)Some secondary issues to address before merging