Conversation
dguittet
requested changes
Jul 28, 2025
Collaborator
dguittet
left a comment
dguittet
left a comment
There was a problem hiding this comment.
This worked! Minor changes requested
| "import PySAM.Utilityrate5 as utility_rate\n", | ||
| "import PySAM.Cashloan as cashloan\n", | ||
| "import PySAM.UtilityRateTools\n", | ||
| "import requests" |
Collaborator
There was a problem hiding this comment.
add print(PySAM.__version__) so we can show it's been tested with the latest version
| "year = 2023\n", | ||
| "\n", | ||
| "sam_api_key = \"YOUR_API_KEY\"\n", | ||
| "sam_email = \"YOUR_EMAIL\"\n", |
Collaborator
There was a problem hiding this comment.
move these key variables to the very top so it's easy to set from the beginning. also, name them nrel_developer_api_key and nrel_developer_email so it's clear it's not SAM-based
added 2 commits
October 24, 2025 10:19
dguittet
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create Jupyter notebook with proof of concept code for running SAM with a green button data XML
Since the example file was from Janine's house, I haven't included it in the repository, but am open to do so after going through it in more detail to remove any PII. (I can share the file internally for the code review).
Also, open to feedback that this is more appropriate for https://github.com/NREL/SAM-analyses than a PySAM example