Lengthen analysis period and max loan term variables#1366
Merged
Conversation
Pull Request Test Coverage Report for Build 20176253872Details
💛 - Coveralls |
mjprilliman
approved these changes
Jan 9, 2026
Collaborator
mjprilliman
left a comment
There was a problem hiding this comment.
Works with NatLabRockies/SAM#2139 checked out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Change ssc vartable limits to allow analysis periods of up to 100 years.
Fixes # NatLabRockies/SAM#2140
The SAM GUI has several seconds of "not responding" when attempting to shorten a long analysis period, but this also occurs on the released version (say changing 50 to 45) so I haven't attempted to address it here.
Corresponding branches and PRs:
Develop of wex, lk, sam-private
SAM PR NatLabRockies/SAM#2139 resolves some related callback issues that make this easier to test, but these are technically independent.
Unit Test Impact:
Open to suggestions on unit test impact
Checklist