Skip to content

Testing branch#10

Open
NatanimA wants to merge 9 commits intomasterfrom
testing-branch
Open

Testing branch#10
NatanimA wants to merge 9 commits intomasterfrom
testing-branch

Conversation

@NatanimA
Copy link
Copy Markdown
Owner

@NatanimA NatanimA commented Oct 5, 2022

PLEASE NOTE THAT THE DRAG AND DROP FUCTIONALITY WAS OPTIONAL AND IT IS NOT IMPLEMENTED IN THE PROJECT OF THE TODO LIST

Tested and passed Insertion and removal of tasks

Tested and Passed Content description Updating and Content Status updating

Please make sure to download the dependencies first

npm install --save-dev jest

JS-DOM is needed as well

npm install -D jest-environment-jsdom

Lastly

npm test

😉

Copy link
Copy Markdown

@mukhammadrizooff mukhammadrizooff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TEAM,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • No linter errors ✔️
  • Good implementations ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Copy link
Copy Markdown

@Davidosky007 Davidosky007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NatanimA 👋,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • All tests passed 👍
  • Proper use of Gitflow 👍

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants