[docs] Fix OB1 gate v2 workflow runs#351
Open
alanshurafa wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
This is the current unblocker for the ingestion PRs (#347-#350). What happened:
What this PR changes:
Local validation passed:
Branch protection blocks me from merging my own PR: it requires at least one approving review from another maintainer. After this lands, I can retrigger #347-#350 and verify the gate on those PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the active OB1 gate workflow file,
.github/workflows/ob1-gate-v2.yml, so fork PRs get a real gate job instead of a zero-job failed workflow run.What changed
pull_request_targetso the base repository workflow is used for fork PRs.refs/pull/<number>/headfor read-only review of the PR contents.pull_request_targetgate runs.Validation
go run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/ob1-gate-v2.yml .github/workflows/ob1-pr-followups.ymlgit diff --checkNotes
The existing PR check for this PR may still be affected by the old gate workflow because workflow changes need to land on
mainbefore they control future PR events.