task-2628: Update Logging to SLF4j in datawave-warehouse/ingest-core pt1 #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apmoriarty
previously approved these changes
Jan 16, 2025
foster33
reviewed
Jan 16, 2025
warehouse/ingest-core/src/main/java/datawave/ingest/data/config/ingest/BaseIngestHelper.java
Outdated
Show resolved
Hide resolved
warehouse/ingest-core/src/main/java/datawave/ingest/data/config/ingest/BaseIngestHelper.java
Outdated
Show resolved
Hide resolved
Co-authored-by: foster33 <[email protected]>
avgAGB
reviewed
Jan 24, 2025
| @@ -64,7 +65,9 @@ public String getNormalizedMaskedValue(final String key) { | |||
| final Set<String> normalizedValues = normalizeFieldValue(fieldName.toUpperCase(), value); | |||
| return normalizedValues.iterator().next(); | |||
| } catch (final Exception ex) { | |||
| log.warn(this.getType().typeName() + ": Unable to normalize masked value of '" + value + "' for " + fieldName, ex); | |||
| if (log.isWarnEnabled()) { | |||
There was a problem hiding this comment.
would it make sense to output this regardless of if the warn level is enabled or not?
| @@ -85,7 +86,9 @@ public EventFieldNormalizerHelper(Configuration config) { | |||
| } else { | |||
| typeFieldMap.put(fieldName, normalizer); | |||
| } | |||
| log.debug("Registered a " + normalizerClass + " for type[" + this.getType().typeName() + "], EVENT (not index) field[" + fieldName + "]"); | |||
| if (log.isDebugEnabled()) { | |||
There was a problem hiding this comment.
same here, just curious if this was too loud of a message before the refactor.
| @@ -223,7 +224,9 @@ public NormalizedContentInterface normalize(NormalizedContentInterface field) { | |||
| if (field.getEventFieldName().equals("IP_GEO_FM_COORDINATES") && field.getEventFieldValue().equals("-99.999/-999.999")) { | |||
| log.warn("Found know bad default value: IP_GEO_FM_COORDINATES=-99.999/-999.999"); | |||
| } else { | |||
| log.error("Failed to normalize " + field.getEventFieldName() + '=' + field.getEventFieldValue(), e); | |||
| if (log.isErrorEnabled()) { | |||
There was a problem hiding this comment.
May be worth considering outputting the error regardless of the conditional
| @@ -45,11 +46,11 @@ public void run() { | |||
| } | |||
|
|
|||
| // verify that we're exeuting in a timely fashion | |||
There was a problem hiding this comment.
Suggested change
| // verify that we're exeuting in a timely fashion | |
| // verify that we're executing in a timely fashion; if not then send out a warning. |
| try { | ||
| tops.create(metadataTableName); | ||
| } catch (TableExistsException tee) { | ||
| log.error(metadataTableName + " already exists someone got here first"); | ||
| log.error("{} already exists someone got here first", metadataTableName); |
There was a problem hiding this comment.
Suggested change
| log.error("{} already exists someone got here first", metadataTableName); | |
| log.error("{} already exists; someone got here first", metadataTableName); |
| @@ -673,11 +676,11 @@ public void run() { | |||
| } | |||
|
|
|||
| // verify that we're exeuting in a timely fashion | |||
| // ..if not warn. | |||
| // if not warn. | |||
There was a problem hiding this comment.
Suggested change
| // if not warn. | |
| // ; if not warn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.