Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add batch support and streaming deduping to SSDeepChainedDiscoveryQueryLogic #2730

Open
wants to merge 6 commits into
base: integration
Choose a base branch
from
Open

Add batch support and streaming deduping to SSDeepChainedDiscoveryQueryLogic #2730

wants to merge 6 commits into from

Conversation

FineAndDandy
Copy link
Collaborator

  • Shift state to config where possible
  • Add configurable hash deduping at both similarity and chaining layers
  • Lazily stream off the similarity iterator when batching is enabled
  • Add batch options to chain strategy

drewfarris
drewfarris reviewed Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@drewfarris drewfarris left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial pass with some comments - I need to spend more time looking at the streaming chained query and test code.

...house/query-core/src/main/java/datawave/query/config/SSDeepSimilarityQueryConfiguration.java Outdated Show resolved Hide resolved
...house/query-core/src/main/java/datawave/query/config/SSDeepSimilarityQueryConfiguration.java Outdated Show resolved Hide resolved
warehouse/query-core/src/main/java/datawave/query/tables/ssdeep/SSDeepSimilarityQueryLogic.java Outdated Show resolved Hide resolved
warehouse/query-core/src/main/java/datawave/query/tables/ssdeep/SSDeepScoringFunction.java Outdated Show resolved Hide resolved
@jack-gitdev
Copy link
Collaborator

I read through everything except the unit tests so far. Will read through again tomorrow and run/go through the unit tests as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewfarris drewfarris drewfarris left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FineAndDandy @jack-gitdev @drewfarris