Skip to content

Website Logos#780

Open
ifTaylor wants to merge 3 commits into
NerdyDayTrips:mainfrom
ifTaylor:website-logos
Open

Website Logos#780
ifTaylor wants to merge 3 commits into
NerdyDayTrips:mainfrom
ifTaylor:website-logos

Conversation

@ifTaylor

@ifTaylor ifTaylor commented Jun 16, 2025

Copy link
Copy Markdown

Enhancement: Add Clickable Logos to Venue Popups

Submitted by: ifTaylor
Purpose: Adding website metadata to popup.

image

Implementation Details

  • Extracts domain name from v.external_url
  • Embeds a Logo.dev image
  • Wraps the image in an anchor element, opening the venue’s site in a new tab
  • Remove explicit pop up height, allowing content to set pop up height

Review Checklist

  • Validate that logo loads successfully
  • Verify fallback behavior when logo is not available (image hides)
  • Confirm layout works across common screen sizes
  • Test popup rendering performance with and without logo

Please review this enhancement and test across several venues.

@ifTaylor

Copy link
Copy Markdown
Author

https://www.logo.dev/ to generate your own publishable key.

@popey

popey commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

Interesting! This is certainly one way to make the popups more interesting, for sure! I'll take a look, thanks.

@popey popey self-requested a review June 17, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants