Skip to content

Conversation

@daimrod
Copy link
Contributor

@daimrod daimrod commented Jan 30, 2012

Hi, I've played a bit more with clesh and I think that there is a
problem with
this commit.

!echo ?(+ 2/3 2/11)

This doesn't work because of THE-ONLY, I've reverted those commits
and it seems to work fine, though you cannot use multiline as you've
used them in the README.

!echo foo\ bar\ baz

This won't work because each line is expected to be a correct command
but the following snippet works:

!echo foo "bar\ baz"\ ls

This will run the two commands as expected.

I've also made a separated package for the unit-test though I don't
know if it's good, I just feel like it's better to have a bijection
between ASDF systems and packages.

@Neronus
Copy link
Owner

Neronus commented Jan 30, 2012

Thanks for your alertness. I never use The !-syntax myself. I guess I should write some unit-tests for it :)
The commit you cite only changes comments, so it can't be that. Did you mean another one?

Regarding the multiline-use of !, I doubt its actual usefulness. I guess it was an artifact of the old implementation. What do you think?

I made those commits to unify the treatment of the escape-character. The policy is described in the README but can be summarized as follows:
Backslashes are left alone except if they appear before a special character (? or ]), in which case they are treated
like you wold treat them in C strings, i.e., a double backslash gives you one backslash.

The use of the-only is probably a mistake. I don't know anymore what I thought when I introduced it.

@Neronus
Copy link
Owner

Neronus commented Jan 30, 2012

Oh yeah, regarding a separate package for testing: As I'm testing internals of clesh, and not only its external interface, I thought that it's useful to have it use the same package.

@daimrod
Copy link
Contributor Author

daimrod commented Jan 30, 2012

Ooops, I was talking about this commit (the one where you introduce the-only.

I think that there is no need to have multiline with ! but not being able to use ? is a problem ;). The old behavior seems fine to me that's why I've reverted the commits.

Concerning a seperated package for testing, I don't know, just do as you whish.

Conflicts:
	README.md
	clesh.lisp
@Neronus
Copy link
Owner

Neronus commented Aug 1, 2013

I guess this issue is closed, isn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants