Skip to content

Revert proxy change #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 14, 2023
Merged

Revert proxy change #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
927a3c4
Revert "Optionally pass in `proxy` parameter to Savon (#548)"
andrewdicken-stripe Apr 19, 2023
0126a42
Restore history to state of master
andrewdicken-stripe Apr 19, 2023
5566dbb
Updates history with current change
andrewdicken-stripe Apr 19, 2023
4421d5e
Revert test file back to state of master
andrewdicken-stripe May 22, 2023
1446251
Random comment change to get another build
andrewdicken-stripe May 22, 2023
b643472
Reverting comment test
andrewdicken-stripe May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
### Added

### Fixed
* Revert recent proxy changes which breaks proxy usage by @andrewdicken-stripe in https://github.com/NetSweet/netsuite/pull/579

### Breaking Changes

Expand Down
2 changes: 1 addition & 1 deletion lib/netsuite/configuration.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ def connection(params={}, credentials={}, soap_header_extra_info={})
logger: logger,
log_level: log_level,
log: !silent, # turn off logging entirely if configured
proxy: proxy,
}.update(params))
client.globals.proxy(proxy) if proxy
cache_wsdl(client)
return client
end
Expand Down