Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: Look for shared Berkeley DB library in versioned subdir too #1911

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Jan 24, 2025

Some environments - notably MacPorts - keep the Berkeley DB shared libraries in a versioned subdir, like what is common with the Berkeley DB include dir. This change makes it so that checking the subdir is a fallback when looking for libraries.

@rdmark rdmark linked an issue Jan 24, 2025 that may be closed by this pull request
@rdmark
Copy link
Member Author

rdmark commented Jan 24, 2025

@trodemaster Would you be able to test if this works in your MacPorts environment?

At first, please try without any bdb parameters.

Copy link

@trodemaster trodemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this change in on my dev system and it's working! Removing both of the build flags for bdp simplifies the config as well. Thanks!

@rdmark rdmark marked this pull request as ready for review January 24, 2025 22:39
@rdmark
Copy link
Member Author

rdmark commented Jan 24, 2025

That's great, thanks for testing! Please let us know if you run into other roadblocks with MacPorts.

@rdmark rdmark merged commit 81f45bf into main Jan 24, 2025
31 checks passed
@rdmark rdmark deleted the 1909-with-bdb-build-args-not-quite-working-for-building-with-macports branch January 24, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

with-bdb build args not quite working for building with macports
2 participants