Skip to content

Remove timing from source compilation test - #45

Merged
DanielThomas merged 1 commit into
mainfrom
test/remove-concurrency-timing
Sep 25, 2026
Merged

DanielThomas merged 1 commit into
mainfrom
test/remove-concurrency-timing

Conversation

@DanielThomas

Copy link
Copy Markdown
Member

Summary

  • replace the timing-based concurrency assertion with a functional compileAll integration test
  • compile two independent valid modules and verify both outputs
  • remove the diagnostic callback barrier that raced with compileAll cancelling peers after the first expected compilation failure

The race appeared in the first v0.16.6 release attempt: https://github.com/Netflix/jig/actions/runs/36107353801/attempts/1

Testing

  • ja test --all (555 tests)

@DanielThomas
DanielThomas merged commit 1cea5e4 into main Sep 25, 2026
1 check passed
@DanielThomas
DanielThomas deleted the test/remove-concurrency-timing branch September 25, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant