Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom rule error handling #761

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Fix custom rule error handling #761

merged 1 commit into from
Mar 19, 2025

Conversation

Andyz26
Copy link
Collaborator

@Andyz26 Andyz26 commented Mar 19, 2025

Context

  • Remove not used runtime exception.
  • UT to validate error behavior: run failure from custom trigger should NOT trigger rule actor restart to avoid short-circuit.

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable

Copy link

Test Results

646 tests  +1   636 ✅ +1   8m 41s ⏱️ +6s
149 suites ±0    10 💤 ±0 
149 files   ±0     0 ❌ ±0 

Results for commit 63670fc. ± Comparison against base commit 8489569.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
io.mantisrx.server.worker.jobmaster.rules.CustomRuleActorTest ‑ testBasic
io.mantisrx.server.worker.jobmaster.rules.CustomRuleActorTest ‑ testHappyRun
io.mantisrx.server.worker.jobmaster.rules.CustomRuleActorTest ‑ testRunError

@Andyz26 Andyz26 merged commit 5bcbb2e into master Mar 19, 2025
4 of 5 checks passed
@Andyz26 Andyz26 deleted the andyz/customRuleErr1 branch March 19, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants