Removing migrated_data_location from definitionMetadata #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevie9868
requested changes
Mar 10, 2025
| @@ -431,6 +431,11 @@ public TableDto deleteAndReturn(final QualifiedName name, final boolean isMView) | |||
| tagService.delete(name, false); | |||
| } else { | |||
| if (config.canSoftDeleteDataMetadata() && tableDto.isDataExternal()) { | |||
| // Remove the migrated_data_location field before soft deleting to allow for cleanup of old prefixes | |||
There was a problem hiding this comment.
Actually, this won't remove the migrated_data_location in the db. We need to delete the migrated_Data_location reference in the metacat db.
|
Could you also add a smokeTest after the change? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.