Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/juno on sedge #333

Open
wants to merge 54 commits into
base: develop
Choose a base branch
from

Conversation

Tomi-3-0
Copy link

@Tomi-3-0 Tomi-3-0 commented Nov 7, 2023

Fixes | Closes | Resolves #

Anything marked as optional that you didn't need to fill in, please remove it from the PR description. Choose one of the keywords above to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666). If there is no issue, remove the line. Remove this note after reading.

Changes:

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Comments about testing , should you have some (optional)

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Tomi-3-0 and others added 30 commits October 21, 2023 22:06
…i. fix: expanded check for EC_API_URL for juno using cli
@Tomi-3-0 Tomi-3-0 marked this pull request as ready for review December 8, 2023 10:33
@Tomi-3-0 Tomi-3-0 requested review from stdevMac and removed request for stdevMac December 8, 2023 10:35
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (9e3e89b) 86.13% compared to head (527f3b0) 86.48%.

Files Patch % Lines
cli/sub_gen.go 90.00% 4 Missing and 2 partials ⚠️
internal/utils/utils.go 50.00% 4 Missing and 2 partials ⚠️
cli/cli.go 93.42% 4 Missing and 1 partial ⚠️
cli/generate.go 85.71% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #333      +/-   ##
===========================================
+ Coverage    86.13%   86.48%   +0.35%     
===========================================
  Files           78       78              
  Lines         4558     4832     +274     
===========================================
+ Hits          3926     4179     +253     
- Misses         547      562      +15     
- Partials        85       91       +6     
Flag Coverage Δ
unittests 86.48% <92.63%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cbermudez97 cbermudez97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM. Good job adding Juno to Sedge. Just some minors questions.

cli/actions/getContainers_test.go Show resolved Hide resolved
cli/cli.go Outdated Show resolved Hide resolved
cli/generate_test.go Outdated Show resolved Hide resolved
configs/messages.go Outdated Show resolved Hide resolved
internal/pkg/generate/generate_scripts.go Outdated Show resolved Hide resolved
internal/pkg/generate/types.go Outdated Show resolved Hide resolved
templates/envs/chiado/starknet/empty.tmpl Outdated Show resolved Hide resolved
internal/ui/gomock_reflect_1086237121/prog.go Outdated Show resolved Hide resolved
Copy link
Contributor

@cbermudez97 cbermudez97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM. Good job adding Juno to Sedge. Just some minors questions.

@Tomi-3-0 Tomi-3-0 requested review from stdevMac and cbermudez97 and removed request for cbermudez97 December 26, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants