-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/juno on sedge #333
base: develop
Are you sure you want to change the base?
Feat/juno on sedge #333
Conversation
…i. fix: expanded check for EC_API_URL for juno using cli
83db1af
to
bdfc4d0
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #333 +/- ##
===========================================
+ Coverage 86.13% 86.48% +0.35%
===========================================
Files 78 78
Lines 4558 4832 +274
===========================================
+ Hits 3926 4179 +253
- Misses 547 562 +15
- Partials 85 91 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM. Good job adding Juno to Sedge. Just some minors questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM. Good job adding Juno to Sedge. Just some minors questions.
…ests for get_Containers test
…into feat/juno-on-sedge merge
…mplates for non-supported networks
Fixes | Closes | Resolves #
Changes:
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Comments about testing , should you have some (optional)
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...