Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Reth Client #377

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

Add Support for Reth Client #377

wants to merge 18 commits into from

Conversation

khalifaa55
Copy link
Contributor

Changes:

  • Add Reth client to Mainnet, Holesky, and Sepolia networks

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (000cc79) to head (d798290).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #377   +/-   ##
========================================
  Coverage    88.06%   88.07%           
========================================
  Files           99       99           
  Lines         5673     5675    +2     
========================================
+ Hits          4996     4998    +2     
  Misses         553      553           
  Partials       124      124           
Flag Coverage Δ
unittests 88.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khalifaa55 khalifaa55 marked this pull request as ready for review May 6, 2024 15:31
@khalifaa55 khalifaa55 requested a review from stdevMac May 6, 2024 15:31
@khalifaa55 khalifaa55 marked this pull request as draft May 28, 2024 18:38
templates/services/merge/execution/reth.tmpl Outdated Show resolved Hide resolved
templates/services/merge/execution/reth.tmpl Outdated Show resolved Hide resolved
templates/services/merge/execution/reth.tmpl Outdated Show resolved Hide resolved
@khalifaa55 khalifaa55 marked this pull request as ready for review June 3, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants