-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prometheus monitoring service #95
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: salaheldinsoliman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. This changes are way cleaner than in the fork. Still minor changed are required
Signed-off-by: salaheldinsoliman <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #95 +/- ##
===========================================
+ Coverage 84.62% 84.87% +0.24%
===========================================
Files 32 32
Lines 1854 1884 +30
===========================================
+ Hits 1569 1599 +30
Misses 230 230
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: salaheldinsoliman <[email protected]>
Signed-off-by: salaheldinsoliman [email protected]
Closes #27
Changes:
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Comments about testing , should you have some (optional)
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...