Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 83f9304385
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -45,6 +45,3 @@ regex = "1" | |||
| serde_json = "1.0" | |||
| type_analysis = { git = "https://github.com/iden3/circom", tag = "v2.2.2" } | |||
| wast = "39.0.0" | |||
There was a problem hiding this comment.
Dropping the [lints] workspace = true stanza from this crate disables all workspace lint policies for circuits (the denies configured in the root Cargo.toml, such as missing_docs, clippy::unwrap_used, and clippy::arithmetic_side_effects). CI still runs cargo clippy with -Dwarnings, but these specific checks are no longer applied to this package, which creates a blind spot in the circuit-generation code path and makes it easier for risky patterns to slip in unnoticed.
Useful? React with 👍 / 👎.
|
I would expect only Cargo.toml changes in this PR. Ok about missing docs but for other lints - why do we omit them, especially related to arithmetics? |
* fix(web): ux polishes * chore(web): reorganize query-client jsdoc * refactor(web): change pay button to scan nomenclature
2 participants
This PR enables workspace lints for crates but relaxes the rules for soroban contracts
Closes #104