fix(app): encrypt note secrets at rest and reuse session keys per account#137
Closed
Yue-Zhou1 wants to merge 1 commit intoNethermindEth:mainfrom
Closed
fix(app): encrypt note secrets at rest and reuse session keys per account#137Yue-Zhou1 wants to merge 1 commit intoNethermindEth:mainfrom
Yue-Zhou1 wants to merge 1 commit intoNethermindEth:mainfrom
Conversation
Contributor
|
we should take into account #139 also and probably consider native sqlite encryption features. |
torisamples
pushed a commit
to torisamples/stellar-private-payments
that referenced
this pull request
Apr 9, 2026
Contributor
|
thanks a lot @Yue-Zhou1 ❤️ we will need to close it as the general refactoring was done #148 but hope to reuse your work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #71.
Summary
privateKeyandblindingbefore storing them in IndexedDB using AES-256-GCM via the Web Crypto API; no new npm dependenciessaveNote()andimportNotes()fail closed instead of falling back to plaintext when encryption keys are not yet derivedA -> B -> AreusesA's cached keysTrade-offs
A -> B -> Aaccount switching.localStorage, orsessionStorage, so refresh and disconnect still require signing again.Test Plan
cd app && npm test -- --runInBand js/__tests__/notes-store.test.jscd app && npm test -- --runInBand js/__tests__/ui.test.jscd app && npm test -- --runInBand