Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the original Stwo code, polynomial commitment scheme is hardcoded to be FRI, with only the backend up for a change.
Since we're planning to integrate circleSTIR, I've decoupled FRI from the general PCS through.
Some FRI-specific code is still spread across different modules (I hope to clean it up a bit as I integrate circleSTIR), we now only need to provide
PolynomialCommitmentSchemewithPolynomialProverandPolynomialVerifierimplementations to make a PCS work.I'm not 100% sure this framework will be able to completely fit both FRI and STIR, but this should make things much easier and minimize changes needed in future.