OpenEphysBinary: Skip streams if folder doesn't exist - #1594
Conversation
zm711
left a comment
zm711
left a comment
There was a problem hiding this comment.
Otherwise this looks good to me. Let me check the GIN really quick :)
| @@ -1,4 +1,5 @@ | |||
| import unittest | |||
| import pytest | |||
| @@ -1,4 +1,5 @@ | |||
| import unittest | |||
| import pytest | |||
There was a problem hiding this comment.
I found a built in unit test function instead..removing!
zm711
left a comment
zm711
left a comment
There was a problem hiding this comment.
Sorry one last question:
Are events and continuous completely separate? Or are they paired in some way? Or can I record just event or just continuous for different experiments? I just want to make sure the skipping stream strategy is best or are there cases where we should raise a hard error. For example what if someone deletes everything will this fail and say empty or would this pass with a bunch of warnings that could be shut off?
|
they could be separate, but some have both. On the NEO side of things, they are separate :) |
2 participants
This has come up several times in the past. If a user deletes a stream subfolder (even if irrelevane, e.g., MessageCenter) the RawIO fails to read the folder.
This PR simply skips missing folders.
@zm711 I'll add a test file to GIN