Skip to content

Fix NeoMatlabIO write_block unused kargs - #1638

Merged
apdavison merged 1 commit into
NeuralEnsemble:masterfrom
TommasoLambresa:fix/NeoMatlabIO-kargs
Jan 30, 2025
Merged

apdavison merged 1 commit into
NeuralEnsemble:masterfrom
TommasoLambresa:fix/NeoMatlabIO-kargs

Conversation

@TommasoLambresa

Copy link
Copy Markdown
Contributor

Fix issue #1636.

@zm711
zm711 requested a review from apdavison January 29, 2025 21:29
@zm711

zm711 commented Jan 29, 2025

Copy link
Copy Markdown
Contributor

I activated our test suite and requested Andrew confirm he is okay with this. But this looks fine to me, Andrew can decide if he wants to explicitly test this. Thanks for the contribution.

@apdavison apdavison linked an issue Jan 30, 2025 that may be closed by this pull request
@apdavison
apdavison merged commit 720e75e into NeuralEnsemble:master Jan 30, 2025
@TommasoLambresa
TommasoLambresa deleted the fix/NeoMatlabIO-kargs branch January 30, 2025 19:13
@zm711

zm711 commented Feb 4, 2025

Copy link
Copy Markdown
Contributor

@TommasoLambresa,

Before our next release I will update our author list. Do you want to be included? If so can I get the name you want and your institutional/work affiliation.

@TommasoLambresa

TommasoLambresa commented Feb 4, 2025 via email

Copy link
Copy Markdown
Contributor Author

@zm711 zm711 added this to the 0.14.1 milestone Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

long_field_names option when writing neo blocks in .mat files

3 participants