Prevent empty seg in random_segment which causes tests to fail stochastically - #1666
Merged
Merged
Conversation
Member
|
I think this is a good solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically we have stochastic failures in this test
python-neo/neo/test/coretest/test_segment.py
Lines 46 to 66 in 74c97fd
because currently we sometimes generate a completely empty segment with nothing in it so the list of
t_startsis empty which causes theminfunction to fail. This makes us have to re-run the test CI to get a result. Instead I made the function recursive such that each segment needs to have at least one of the types of children objects for testing purposes (to be clear it just needs one so if the n_child is 0 for all types of children then it fails which is what causes the test to stochastically fail).The other option would be to change the test to accept the fact we have an empty segment. So let me know what you think @apdavison !