Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EHN] creating the metainformation file to allow lazy loading by default #688

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

bruAristimunha
Copy link
Collaborator

I am improving the dataset with the speech brain team (@mravanelli, @Drew-Wagner).

Including this step when you create the mne_bids folder would be good. What do you think @PierreGtch?

@PierreGtch
Copy link
Collaborator

Hi @bruAristimunha, I think supporting lazy loading would be great! Was there any previous PR in this direction?

However, I don’t think we need this PR to achieve lazy loading of BIDS datasets. mne_bids.find_matching_paths is fast and we can call it every time. Plus this metadata file makes us diverge from the BIDS specifications...

@bruAristimunha
Copy link
Collaborator Author

Hmmm, got it, do you think just use on the braindecode part would be better?

@PierreGtch
Copy link
Collaborator

Maybe we could have this as a utils function? Let’s discuss it next moabb/braindecode meeting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants