Repository navigation
Prepare for 0.4 release - #340
Merged
Merged
Conversation
…exedCellValues
…unknown columns are provided
…redColumnsFromFile and support variable index data types for VectorIndex columns in DynamicTable::addRows
oruebel
marked this pull request as ready for review
September 3, 2026 05:35
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
==========================================
+ Coverage 83.66% 83.68% +0.01%
==========================================
Files 71 71
Lines 4280 4296 +16
Branches 624 627 +3
==========================================
+ Hits 3581 3595 +14
- Misses 699 701 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rly
reviewed
Sep 3, 2026
rly
reviewed
Sep 3, 2026
rly
previously approved these changes
Sep 3, 2026
Co-authored-by: Ryan Ly <310197+rly@users.noreply.github.com>
Co-authored-by: Ryan Ly <310197+rly@users.noreply.github.com>
rly
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdCMakeLists.txtisISO8601Daterejects valid ISO 8601 timestamps, including the form the NWB schema recommends #329strideandblockparameters from the newVectorIndex::readIndexedCellValues. The parameters were not being used yet and supporting this ully would require more runtime checks. We can add support for this later if it becomes necessary.VectorIndexcolumns inDynamicTable::loadConfiguredColumnsFromFileto support reopening a file with indexed columns and appending to it. UpdatedDynamicTable::addRowsto supportVectorIndexwith different data types (previously it assumeduint32)