Repository navigation
Regenerate the reducer test fixture with asv 0.6.6 - #208
Merged
CodyCBakerPhD merged 3 commits intoOct 7, 2026
Merged
Conversation
The raw results fixture for `test_reduce_results.py` was written with asv 0.6.1. The environment now pins asv 0.6.6 and asv-runner 0.3.1, so regenerate it with those versions from the same toy suite (Incremental, Network, Timed and Unwrapped benchmarks, run with `--python=same --record-samples` and a `--bench` pattern selecting only parameter set A of `Timed`), trimmed to the keys the reducer reads, with the same fixed commit hash. The structure is unchanged from 0.6.1: the same result columns, row lengths, NaN result for the unselected parameter set and `null` samples for the failed one. Only the timing, the benchmark version hashes, `started_at` and `duration` differ. Rename the file to `asv_0.6.6_raw_results.json` to match and update the test comment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01At337MLAynHQXz3TZBF3Vv
CodyCBakerPhD
marked this pull request as ready for review
October 7, 2026 15:49
Collaborator
Author
|
OK, phew, looks like nothing changed |
CodyCBakerPhD
merged commit Oct 7, 2026
952da08
into
add_time_slicing_benchmark
1 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #203 (targets its branch). The raw results fixture behind
tests/test_reduce_results.pywas written with asv 0.6.1. Main now pins asv 0.6.6 and asv-runner 0.3.1 (#205), so this PR regenerates the fixture with those versions.Changes
maininto the branch. It merges cleanly and brings in the Upgrade pinned dependencies to Python 3.14 #205 pins, so the tests in this PR run against the asv version that wrote the fixture.Incremental(B raises),Network,Timed(--benchselects only parameter set A) andUnwrapped. The suite was run withasv run --python=same --record-samplesand trimmed to the keys the reducer reads, with the same fixed commit hash.tests/data/asv_0.6.1_raw_results.json→asv_0.6.6_raw_results.json, and updates the path and comment in the test.What changed in the fixture
The structure is the same as under 0.6.1: same
result_columns, same row lengths (12 for the wrapped benchmarks, 5 forUnwrapped), NaN result for the unselectedTimedB,nullsamples for the failedIncrementalB, and the sametrueresults for the wrappedtrack_benchmarks. Only theTimedtiming, the benchmark version hashes,started_atanddurationdiffer.No version bump: nothing under
src/nwb_benchmarks/changes.Testing
python -m pytest tests: 40 passed, none skipped (polars and seaborn installed, so the database-reader test ran).pre-commit runon the changed files passes.🤖 Generated with Claude Code
https://claude.ai/code/session_01At337MLAynHQXz3TZBF3Vv
Generated by Claude Code