Repository navigation
Distinguish unconsolidated Zarr by color, line style and marker; bump version (follow-up to #201) - #215
Merged
CodyCBakerPhD merged 5 commits intoOct 11, 2026
Conversation
…to 0.2.1 The purple previously assigned to 'zarr s3 force no consolidated' differed from the yellow of 'zarr s3' mostly in hue, so swap it for a dark brown that also differs in brightness. Bump the package version since code under src/nwb_benchmarks/ changed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E6ccBQPZ1RBwpZvme23B2t
CodyCBakerPhD
marked this pull request as ready for review
October 11, 2026 19:51
The unconsolidated Zarr method is a variant of the Zarr method, so in addition to its color it is now drawn with a dash-dot line and square markers in every plot that connects points per method: the slicing and file-open network-vs-runtime plots, the slice-size and version point plots, and the download-vs-stream extrapolations. Dash-dot is used so the variant does not look like the dashed throughput guide lines. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E6ccBQPZ1RBwpZvme23B2t
CodyCBakerPhD
changed the title
… into claude/inspiring-maxwell-x2yt6u
Main now carries 0.2.1, so the bump for the visualization changes needs to go one patch further. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E6ccBQPZ1RBwpZvme23B2t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies both suggestions from #201, which @oruebel agreed to in this comment. Targets the
fix_method_colorsbranch so it folds into #201.#9467BD(purple) for#8C510A(dark brown) as the color ofzarr s3 force no consolidated, so it differs from the yellow ofzarr s3in brightness as well as hue. Thepynwbvariant picks up the same color through the existing derived mapping.zarr s3by line style and marker as well: it is drawn dash-dot with square markers (newDEFAULT_METHOD_LINESTYLES/DEFAULT_METHOD_MARKERSnext toDEFAULT_METHOD_COLORS, with the same PyNWB derivation). Applied in every plot that connects points per method: the slicing and file-open network-vs-runtime plots (legend handles included), the slice-size and performance-over-versions point plots via seaborn'smarkers/linestyles, and the download-vs-stream extrapolation lines. Dash-dot rather than dashed so the variant does not collide with the dashed gray throughput guide lines added in Fix coloring of methods and add throughput lines in network vs runtime plots #201.0.2.2(main is now at0.2.1after Fix recording the current environment #210), since Fix coloring of methods and add throughput lines in network vs runtime plots #201 changes code undersrc/nwb_benchmarks/and itsversion-checkCI run is currently failing for the missing bump (patch bump perAGENTS.md: a fix that leaves what the benchmarks measure alone).Smoke-tested each changed plot path on synthetic data;
blackandisortpass.🤖 Generated with Claude Code
https://claude.ai/code/session_01E6ccBQPZ1RBwpZvme23B2t