Add support for NWB schema 2.7.0 #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1820 +/- ##
==========================================
- Coverage 91.96% 91.81% -0.15%
==========================================
Files 27 27
Lines 2663 2627 -36
Branches 686 688 +2
==========================================
- Hits 2449 2412 -37
Misses 142 142
- Partials 72 73 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Steph Prince <[email protected]>
…gsTable (#1815) * add stimulus template column option to IntracellularRecordingsTable * add tests for stimulus template column * add example in tutorial for adding stimulus template data * link to nwb-schema PR with stimulus template change * update changelog * add empty TimeSeriesReference method * point to updated nwb-schema PR * remove test caught by docval argument checking * Apply suggestions from code review Co-authored-by: Oliver Ruebel <[email protected]> * update tutorial and documentation * Update src/pynwb/base.py Co-authored-by: Ryan Ly <[email protected]> * Update CHANGELOG.md --------- Co-authored-by: Ryan Ly <[email protected]> Co-authored-by: Oliver Ruebel <[email protected]>
* Update retinotopy.py * Remove references to retinotopy module * Update schema * Fix test * Updated changelog * Update schema submodule * Update test_retinotopy.py * Update retinotopy.py * Update test_retinotopy.py * Update retinotopy.py * Update test_retinotopy.py * Update retinotopy.py * Update test_retinotopy.py * RuntimeError -> ImportError * Update schema * Revert "Update schema" This reverts commit 08f3a88. * Update schema
rly
requested review from
oruebel and
bendichter
and removed request for
oruebel
* Exclude pynwb retinotopy from sphinx * Update conf.py * Update conf.py * Update conf.py * Fix sphinx apidoc exclude
oruebel
reviewed
Feb 16, 2024
oruebel
previously approved these changes
Feb 16, 2024
auto-merge was automatically disabled
February 16, 2024 01:30
Rebase failed
oruebel
previously approved these changes
Feb 24, 2024
auto-merge was automatically disabled
February 24, 2024 02:14
Rebase failed
|
The NWB Tutorial at Cosyne is this Thursday. In case adding support for NWB schema 2.7.0 causes any last minute issues in PyNWB, MatNWB, or other tools, like NWB GUIDE, I would like to hold off of merging this and making new releases until after March 4. |
3 tasks
oruebel
approved these changes
Mar 26, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squash and merge NWB schema 2.7.0-related PRs to this branch.
When ready to merge: