-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance unit test coverage #2031
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2031 +/- ##
==========================================
+ Coverage 91.73% 94.22% +2.48%
==========================================
Files 27 27
Lines 2722 2718 -4
Branches 710 708 -2
==========================================
+ Hits 2497 2561 +64
+ Misses 149 94 -55
+ Partials 76 63 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@stephprince should this PR target the |
Since you mentioned there are breaking changes, I think this should target the 3.0 release branch. But I can review and take a closer look. |
Sounds good. Feel free to modify the PR as necessary. If you prefer, it should be pretty straight forward to just move the breaking changes to a separate PR since its just removes a few functions that were no longer used anywhere. |
…allowed for read of old data
68deffc
to
eba14a8
Compare
@stephprince @rly to simplify things I have moved all breaking changes to a new PR #2036. This PR is good to go from my end. |
Motivation
Add unit tests to enhance overall test coverage for
core.py
,image.py
,spec.py
,icephys.py
,epoch.py
IntracellularRecordingsTable
, theIntracellularResponseTable
was not being initialized correctly when empty category tables were providedSpikeEventSeries
to handle the case whereAbstractDataChunkIterator
are used for timestamps/dataChecklist
ruff check . && codespell
from the source directory.