Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods from NWBFile #2033

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Feb 7, 2025

Motivation

This PR removes previously deprecated functions and parameter from NWBFile

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.83%. Comparing base (716e3ce) to head (9ce6ef4).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2033      +/-   ##
==========================================
+ Coverage   91.73%   91.83%   +0.10%     
==========================================
  Files          27       27              
  Lines        2722     2683      -39     
  Branches      710      702       -8     
==========================================
- Hits         2497     2464      -33     
+ Misses        149      144       -5     
+ Partials       76       75       -1     
Flag Coverage Δ
integration 73.46% <100.00%> (+0.50%) ⬆️
unit 82.25% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oruebel oruebel marked this pull request as ready for review February 7, 2025 06:19
@oruebel oruebel changed the base branch from dev to release-3.0.0 February 7, 2025 06:19
@oruebel oruebel changed the base branch from release-3.0.0 to dev February 7, 2025 06:21
@oruebel
Copy link
Contributor Author

oruebel commented Feb 7, 2025

@stephprince @rly not sure if this should be for 3.0 or 4.0 release

@oruebel oruebel requested review from rly and stephprince February 7, 2025 06:22
@stephprince
Copy link
Contributor

I think these changes are all covered by #2011, which was merged into the release-3.0.0 branch but has not yet been merged into dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants