refactor: 로그아웃 기능 수정 #86
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gyulo94
requested review from
JuwoongKim,
shinbumjun and
yoonicorn9227
as code owners
Open
JuwoongKim
approved these changes
Jul 17, 2024
| type: 'POST', | ||
| success: () => { | ||
| sessionStorage.setItem('logoutMessage', '정상적으로 로그아웃 되었습니다.'); | ||
| window.location.href = '/sign-in'; |
There was a problem hiding this comment.
화면 이동해도 데이터를 쓰기 위해서 sessionStorage를 사용하는 군요!!
원래 sessionStorage를 이렇게 사용하나용 (텍스트라 그렇지 궁금해서 물어보는겁니다)
이게 뭔가 key를 한쪽에서 관리하지 않으면 나중에 문제가 생길 수 있을 것 같은 기분이 들긴합니다.
JuwoongKim
force-pushed
the
main
branch
7 times, most recently
from
63789d4 to
529b938
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 PR 설명
🖋️ 주요 작업
📢 기타