Conversation
yurii-litvinov
left a comment
yurii-litvinov
left a comment
There was a problem hiding this comment.
В целом ок, но надо чуть доделать
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net7.0</TargetFramework> |
Homework2.Tests/LazyTests.cs
Outdated
| @@ -0,0 +1,81 @@ | |||
| | |||
There was a problem hiding this comment.
Лишняя пустая строчка (по-хорошему, тут должна быть шапка с лицензией, но ладно)
| int localI = i; | ||
| threads[i] = new Thread(() => | ||
| { | ||
| arrayOfResults[localI] = lazy.Get()!; |
There was a problem hiding this comment.
Лучше "!" вообще никогда не пользоваться, потому что он убивает весь профит от nullability-анализа. Проверяйте явно на null лучше.
There was a problem hiding this comment.
Не поправлено. Можно, кстати, lazy.Get() ?? new Object();
| thread.Start(); | ||
| } | ||
|
|
||
| manualResetEvent.Set(); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Homework2/ILazy.cs
Outdated
| @@ -0,0 +1 @@ | |||
| public interface ILazy<T> { T? Get(); } No newline at end of file | |||
There was a problem hiding this comment.
Надо комментарии и больше переводов строк. В C# по стайлгайду фигурная скобка одни на строке
Homework2/LazyMultyThread.cs
Outdated
| finally | ||
| { | ||
| supplier = null; | ||
| isFirstCall = false; |
There was a problem hiding this comment.
В свете строки ниже эта строка не нужна
| } | ||
| throw supplierException!; | ||
| } | ||
|
|
There was a problem hiding this comment.
Тут тоже пустая строчка не нужна
|
|
||
|
|
There was a problem hiding this comment.
Лишние пустые строчки. Если они даже при беглом просмотре кода не бросаются Вам в глаза, Вам надо первый курс раззачесть :)
| int localI = i; | ||
| threads[i] = new Thread(() => | ||
| { | ||
| arrayOfResults[localI] = lazy.Get()!; |
There was a problem hiding this comment.
Не поправлено. Можно, кстати, lazy.Get() ?? new Object();
| /// </summary> | ||
| public interface ILazy<T> | ||
| { | ||
| T? Get(); |
| } | ||
| throw supplierException!; | ||
| } | ||
|
|
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net7.0</TargetFramework> |
2 participants
No description provided.