Integrate nilDB <> nilComm to support writes / executes from chain #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File Coverage |
tim-hm
force-pushed
the
feat/blockchain-integrations
branch
2 times, most recently
from
29af379 to
58fe4e4
Compare
tim-hm
changed the title
tim-hm
force-pushed
the
feat/blockchain-integrations
branch
2 times, most recently
from
83c5e44 to
3123854
Compare
# Conflicts: # src/env.ts # src/main.ts
…...` � Conflicts: � src/accounts/accounts.openapi.yaml � src/accounts/accounts.repository.ts � src/admin/admin.types.ts � src/system/system.openapi.yaml
This unifies log formatting between prod, local and test envs and fixes an issue where log messages in Intellij were not shown in the vitest runner.
…ain auctions via nilcomm
- correct start query result event shape - flatten error logging - correctly decrypt secret share using node sk
Although this test omits the nilcomm service, it simulates an end to end blind action tests where: 1. User provide bids 2. Bids are encrypted using the node's public key and ECIES 3. "Bids shares" are stored in plain text 4. The commit reveal query is called 5. The commit reveal query returns all bid shares in plain text 6. The highest bidder is correctly selected
…test env feature If nilcomm is required in a test it should be enabled via a test fixture parameter because enabling it via .env.test causes conflicting consumers and producers in multiple suites. This isn't an ideal solution and will need to be matured in time. This also now correctly closes the fixtures mq channel and connection.
This cannot be fixed in the short term since it's being replaced by NUCs and nilAuth. So this reverts to the original behaviour which set subscriptions to active on testnet by default. Also, tidied up logging in main.
tim-hm
force-pushed
the
feat/blockchain-integrations
branch
from
28d37cc to
af78f45
Compare
Id is generic and so for nilcomm related events we'll use the more verbose `mapping_id` to better label its purpose.
|
This feature is not done as it's waiting on integration testing feedback but I'm going to merge this to avoid divergence. To reduce risk, the nilcomm feature and tests are disabled by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #126