Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add NUC token builder #5

Merged
merged 1 commit into from
Mar 11, 2025
Merged

feat: add NUC token builder #5

merged 1 commit into from
Mar 11, 2025

Conversation

mfontanini
Copy link
Member

This adds a builder for NUC tokens that performs signatures and creates proof chains. Tests again were ported over from the rust impl.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13772601848

Details

  • 102 of 104 (98.08%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 94.444%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/nuc/builder.py 86 88 97.73%
Totals Coverage Status
Change from base Build 13769569990: 1.1%
Covered Lines: 442
Relevant Lines: 468
💛 - Coveralls

@mfontanini mfontanini marked this pull request as ready for review March 10, 2025 19:02
jimouris
jimouris approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@jimouris jimouris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@mfontanini mfontanini merged commit c986c44 into main Mar 11, 2025
4 checks passed
@mfontanini mfontanini deleted the feat/builder branch March 11, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumasepa lumasepa lumasepa approved these changes

@jimouris jimouris jimouris approved these changes

@pablojhl pablojhl pablojhl approved these changes

@tim-hm tim-hm Awaiting requested review from tim-hm

@andreasbros andreasbros Awaiting requested review from andreasbros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mfontanini @coveralls @lumasepa @jimouris @pablojhl