Updated to Flutter 3.29.3

.fvmrc

@@ -0,0 +1,4 @@
+{
+  "flutter": "3.29.3",
+  "flavors": {}
+}

.github/workflows/pr-checks.yaml

@@ -0,0 +1,84 @@
+name: PR checks
+
+on:
+  workflow_dispatch:
+  pull_request:
+    branches: [master]
+
+jobs:
+  android-build:
+    name: Android example build
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-java@v4
+        with:
+          distribution: 'zulu'
+          java-version: '17'
+      - uses: kuhnroyal/flutter-fvm-config-action/setup@v3
+      - run: flutter pub get
+        working-directory: example
+      - run: flutter build apk
+        working-directory: example
+      - uses: actions/upload-artifact@v4
+        with:
+          name: android-build
+          path: |
+            example/build/app/outputs/flutter-apk/app-release.apk
+  flutter-lint:
+    name: Flutter lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: kuhnroyal/flutter-fvm-config-action/setup@v3
+      - run: |
+          flutter pub get
+          flutter analyze
+
+  ios-build:
+    name: iOS build
+    runs-on: macos-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: kuhnroyal/flutter-fvm-config-action/setup@v3
+      - run: flutter pub get
+        working-directory: example
+      - run: flutter build ios --release --no-codesign
+        working-directory: example
+      - uses: actions/upload-artifact@v4
+        with:
+          name: ios-build
+          path: |
+            example/build/ios/iphoneos/Runner.app
+
+  macos-build:
+    name: MacOS Build
+    runs-on: macos-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: kuhnroyal/flutter-fvm-config-action/setup@v3
+      - run: flutter config --enable-macos-desktop
+        working-directory: example
+      - run: flutter build macos
+        working-directory: example
+      - uses: actions/upload-artifact@v4
+        with:
+          name: windows-build
+          path: |
+            example/build/macos/Build/Products/Release/flutter_nsd_example.app
+
+  windows-build:
+    name: Windows build
+    runs-on: windows-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: kuhnroyal/flutter-fvm-config-action/setup@v3
+      - run: |
+          cd example/
+          flutter config --enable-windows-desktop
+          flutter build windows
+      - uses: actions/upload-artifact@v4
+        with:
+          name: windows-build
+          path: |
+            example/build/windows/runner/Release/

.gitignore

@@ -9,7 +9,6 @@
 .history
 .svn/
 migrate_working_dir/
-.fvm/flutter_sdk
 
 # IntelliJ related
 *.iml
@@ -44,3 +43,6 @@ app.*.map.json
 /android/app/debug
 /android/app/profile
 /android/app/release
+
+# FVM Version Cache
+.fvm/

android/build.gradle

@@ -15,62 +15,44 @@
  *
  */
 
+plugins {
+  id "com.android.library"
+  id "kotlin-android"
+}
+
 group 'com.nimroddayan.flutternsd'
 version '1.0-SNAPSHOT'
 
-buildscript {
-    ext.kotlin_version = '1.7.10'
-    repositories {
-        google()
-        mavenCentral()
-    }
-
-    dependencies {
-        classpath 'com.android.tools.build:gradle:7.3.1'
-        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
-    }
-}
-
 rootProject.allprojects {
-    repositories {
-        google()
-        mavenCentral()
-    }
+  repositories {
+    google()
+    mavenCentral()
+  }
 }
 
-apply plugin: 'com.android.library'
-apply plugin: 'kotlin-android'
-
 android {
-    // Conditional for compatibility with AGP <4.2.
-    if (project.android.hasProperty("namespace")) {
-        namespace 'com.nimroddayan.flutternsd'
-    }
-
-
-    compileSdkVersion 34
-
-    sourceSets {
-        main.java.srcDirs += 'src/main/kotlin'
-    }
-    defaultConfig {
-        minSdkVersion 21
-    }
-    lintOptions {
-        disable 'InvalidPackage'
-    }
-
-    compileOptions {
-        sourceCompatibility = JavaVersion.VERSION_1_8
-        targetCompatibility = JavaVersion.VERSION_1_8
-    }
-
-    kotlinOptions {
-        jvmTarget = "1.8"
-    }
+  namespace = "com.nimroddayan.flutternsd"
+  compileSdkVersion 35
+
+  compileOptions {
+    sourceCompatibility = JavaVersion.VERSION_11
+    targetCompatibility = JavaVersion.VERSION_11
+  }
+
+  kotlinOptions {
+    jvmTarget = JavaVersion.VERSION_11
+  }
+
+  sourceSets {
+    main.java.srcDirs += "src/main/kotlin"
+    test.java.srcDirs += "src/test/kotlin"
+  }
+
+  defaultConfig {
+    minSdk = 21
+  }
 }
 
 dependencies {
-    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
-    implementation 'com.jakewharton.timber:timber:4.7.1'
+  implementation 'com.jakewharton.timber:timber:5.0.1'
 }

android/src/main/AndroidManifest.xml

@@ -15,8 +15,7 @@
   ~
   -->
 
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-  package="com.nimroddayan.flutternsd">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">
     <uses-permission android:name="android.permission.INTERNET"/>
     <uses-permission android:name="android.permission.NEARBY_DEVICES" />
 </manifest>

android/src/main/kotlin/com/nimroddayan/flutternsd/FlutterNsdPlugin.kt

@@ -62,17 +62,6 @@ class FlutterNsdPlugin : FlutterPlugin, MethodCallHandler {
     Timber.d("Plugin initialized successfully")
   }
 
-  // This static function is optional and equivalent to onAttachedToEngine. It supports the old
-  // pre-Flutter-1.12 Android projects. You are encouraged to continue supporting
-  // plugin registration via this function while apps migrate to use the new Android APIs
-  // post-flutter-1.12 via https://flutter.dev/go/android-project-migration.
-  //
-  // It is encouraged to share logic between onAttachedToEngine and registerWith to keep
-  // them functionally equivalent. Only one of onAttachedToEngine or registerWith will be called
-  // depending on the user's project. onAttachedToEngine or registerWith must both be defined
-  // in the same class.
-
-
   override fun onMethodCall(@NonNull call: MethodCall, @NonNull result: Result) {
     if (nsdManager == null) {
       result.error("1000", "NsdManager not initialized", null)

example/.fvmrc

@@ -0,0 +1,4 @@
+{
+  "flutter": "3.29.3",
+  "flavors": {}
+}