Add BLAKE3 hashing algorithm #12379
Add BLAKE3 hashing algorithm #12379
Conversation
|
Nice! |
No, but I'm also not sure if that is a meaningful thing we can do in this context. Maybe you can elaborate if you have something specific in mind? I don't know much about tvix but from scanning the documentation and source code it appears that their use of BLAKE3 is primarily for their custom data model and protocols around interacting with the content addressable store, which as far as I know is not directly comparable to the equivalent in C++ nix. It would theoretically be possible to re-implement what they have done for the castore here but it would be a lot more work, beyond the scope of this PR, and certainly beyond my current knowledge of nix internals. What this PR does is just add BLAKE3 as another hashing algorithm, which could presumably be used for anything nix does internally related to hashing, but at the moment is only really exposed for SRI hashes and via the CLI interface for Surprisingly, tvix doesn't seem to support BLAKE3 for SRI hashes though: https://github.com/tvlfyi/tvix/blob/f8325a64845500916f1e40f5d04466d4c7d1bef6/eval/src/builtins/hash.rs#L19-L29 |
|
I asked in #tvix-dev |
This uses the single-threaded C-based routines from libblake3. This is not optimal performance-wise but should be a good starting point for nix compatibility with BLAKE3 hashing until a more performant implementation based on the multi-threaded BLAKE3 routines (written in Rust) can be developed.
Because we're trying to be compatible with with Nix. |
| @@ -10,6 +10,19 @@ namespace nix { | |||
| * hashString | |||
| * --------------------------------------------------------------------------*/ | |||
|
|
|||
There was a problem hiding this comment.
There doesn't seem to be tests added for the SRI hash formats.
This uses the single-threaded C-based routines from libblake3.
This is not optimal performance-wise but should be a good starting point for nix compatibility with BLAKE3 hashing until a more performant implementation based on the multi-threaded BLAKE3 routines (written in Rust) can be developed.
@Ericson2314
Motivation
See below.
Context
#10600 #11999